Move microp_aero (BAM: ndrop_bam, nucleate_ice, interstitials) to atmos_phys#1579
Open
jimmielin wants to merge 3 commits into
Open
Move microp_aero (BAM: ndrop_bam, nucleate_ice, interstitials) to atmos_phys#1579jimmielin wants to merge 3 commits into
jimmielin wants to merge 3 commits into
Conversation
… and MAM/CARMA Initial try (v2) at unifying nucleate_ice_cam paths in microp_aero for BAM and MAM/CARMA Tentative CCPP scheme for ndrop_bam. b4b fix Add ncol_ to aerosol_state for internal loops Add subgrid vertical velocity (wsub) schemes; further clean up ndrop_bam Move ndrop_bam, nucleate_ice core code etc. into atmos_phys: microp_aero Use ndrop_bam driver, not ccpp run phase Fix wrong pointer in driver subroutine Update interface to ndrop_bam to get naer_all from init phase clubb variant B4B fixes (incl. QPC failure in Izumi fix)
…data to host. Renames aerosol_mmr_cam -> aerosol_mmr_host; get_cam_idx -> get_host_idx. This will minimize the number of diverging changes between the CAM and SIMA trees on the aerosol abstract interface. Assisted-by: claude-fable:5[1m]
…tent lookup for non-BAM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of changes (include the issue number and title text for each relevant GitHub issue):
microp_aero(nucleate_ice, ndrop_bam, interstitials) to atmospheric_physicsnucleate_ice_cam.aero_host_binding_ttype to removestateandpbuffrom being directly contained within the abstract aerosol interface (*_aerosol_state), so CAM and CAM-SIMA code are less divergent with each other.List all files eliminated:
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes: