[#2590] Prevent Runtimes in Journals from Breaking Everything#2676
Merged
Rixxan merged 1 commit intoJun 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resovles an edge case where unhandled exceptions during file ops (specifically
export_ship()andnotify_journal_entry()) could result in a situation where Plugins never receive game data.This PR decouples heavy filesystem events from the main application thread and uses a
ThreadPoolExecutorto handle these events instead. This also includes an upgrade to use Python's pattern-matching case features instead of larger if-else loops, which helps ensure a more manageable codebase.Type of Change
Enhancement
How Tested
Tested to ensure the thread shuts down cleanly, and that the Case entry properly gathers the required information from the journal.
Notes
Resolves #2590.