Skip to content

[Feat] 나만아니면돼 가리기 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeraSite merged 3 commits into from
Mar 31, 2026
Merged

[Feat] 나만아니면돼 가리기 #514

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e15ebfd
feat: 나만아니면돼 팝업 가리는 flag 추가
PeraSite Mar 29, 2026
97bddb0
fix: 나만아니면돼 툴팁 숨김
PeraSite Mar 29, 2026
3df1fc2
refactor: 나만아니면돼 플래그 통합
PeraSite Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/com/eatssu/android/presentation/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ class MainActivity : BaseActivity<ActivityMainBinding>(
ActivityMainBinding::inflate,
ScreenId.HOME_MAIN
) {
companion object {
private const val ENABLE_ANYONE_BUT_ME_POPUP = false
}
Comment on lines +47 to +49

@gemini-code-assist gemini-code-assist Bot Mar 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a hardcoded constant for a feature flag can be risky, as it might be forgotten and lead to shipping the feature in an unintended state. Consider using a more robust feature flagging mechanism, such as BuildConfig fields for different build types (e.g., debug, release), or a remote configuration service. This would make managing feature availability safer and more flexible.

For example, with BuildConfig, you could define in app/build.gradle:

buildTypes {
    debug {
        buildConfigField "boolean", "ENABLE_ANYONE_BUT_ME_POPUP", "true"
    }
    release {
        buildConfigField "boolean", "ENABLE_ANYONE_BUT_ME_POPUP", "false"
    }
}

And then use BuildConfig.ENABLE_ANYONE_BUT_ME_POPUP in your code.


@Inject
lateinit var workManager: WorkManager
Expand All @@ -63,7 +66,7 @@ class MainActivity : BaseActivity<ActivityMainBinding>(

setupNoToolbar()
setNavigation()
bindEventPopup(showOnLaunch = savedInstanceState == null)
bindEventPopup(showOnLaunch = ENABLE_ANYONE_BUT_ME_POPUP && savedInstanceState == null)
bindEventTooltip()

checkAlarmPermission()
Expand Down
Loading