Skip to content

Add new GregClient constructor to accept custom http client #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aparajit-pratap merged 3 commits into from
May 27, 2025
Merged

Add new GregClient constructor to accept custom http client #116

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec8057e
add new GregClient constructor to accept custom http client
aparajit-pratap May 22, 2025
31641ae
Update src/GregClient/GregClient.cs
aparajit-pratap May 22, 2025
8ffc5d9
refactor dup code into helper
aparajit-pratap May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/GregClient/GregClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using RestSharp;
using System;
using System.Net;
using System.Net.Http;

namespace Greg
{
Expand All @@ -19,8 +20,6 @@ public IAuthProvider AuthProvider

public GregClient(IAuthProvider provider, string packageManagerUrl)
{


// https://stackoverflow.com/questions/2819934/detect-windows-version-in-net
// if the current OS is windows 7 or lower
// set TLS to 1.2.
Expand All @@ -33,6 +32,25 @@ public GregClient(IAuthProvider provider, string packageManagerUrl)
_client = new RestClient(packageManagerUrl);
}

Comment thread
aparajit-pratap marked this conversation as resolved.
public GregClient(IAuthProvider provider, string packageManagerUrl, HttpClient httpClient)
Comment thread
aparajit-pratap marked this conversation as resolved.
{
// https://stackoverflow.com/questions/2819934/detect-windows-version-in-net
// if the current OS is windows 7 or lower
// set TLS to 1.2.
// else do nothing and let the OS decide the version of TLS to support. (.net 4.7 required)
if (System.Environment.OSVersion.Version.Major <= 6 && System.Environment.OSVersion.Version.Minor <= 1)
{
ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12;
}
_authProvider = provider;

var baseUrl = new Uri(packageManagerUrl);
if (httpClient != null)
_client = new RestClient(httpClient, new RestClientOptions() { BaseUrl = baseUrl });
else
_client = new RestClient(packageManagerUrl);
Comment thread
aparajit-pratap marked this conversation as resolved.
}

private RestResponse ExecuteInternal(Request m)
{

Expand Down