D4 r da 2027

[pinzart90]

Please Note:

1. Before submitting the PR, please review How to Contribute to Dynamo
2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
3. PRs will be reviewed from oldest to newest
4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

• The code base is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

[mjkkirschner]

@pinzart90 are you looking for a review on this or just getting it spun up?

[Copilot]

Pull request overview

This PR introduces Design Automation (DA) support for DynamoRevit (targeting Revit 2027 / .NET 10), refactors ASM/libG preloading + assembly resolving into shared utilities, and updates Revit services/nodes/UI to compile/run under a headless DA build profile (DESIGN_AUTOMATION).

Changes:

• Added DADynamoApp (DA entrypoint, logging/profiling, graph-run routing) and a dedicated DynamoRevit.DA.sln.
• Introduced DA compile-time slicing (DESIGN_AUTOMATION) and updated RevitServices/RevitNodes/RevitNodesUI to avoid Revit UI APIs in DA builds.
• Refactored ASM preload and internal node loading utilities, and centralized assembly resolution logic.

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
test/Libraries/RevitTestServices/RevitSystemTestBase.cs	Switches ASM/libG preload + geometry factory path resolution to ASMPrealoaderUtils.
test/Libraries/RevitTestServices/RevitNodeTestBase.cs	Uses ASMPrealoaderUtils.PreloadAsmFromRevit for test session setup.
test/Libraries/RevitServicesTests/RevitServicesTests.csproj	Removes config-specific MSBuild property groups.
test/Libraries/RevitNodesTests/Elements/DirectShapeTests.cs	Updates mesh creation helper calls to Mesh.ByPointsFaceIndices.
test/Libraries/RevitIntegrationTests/RevitSystemTests.csproj	Adds DADynamoApp project reference for integration testing.
test/Libraries/RevitIntegrationTests/DALoggerTests.cs	Adds DA logger/profiling integration test coverage (currently hits access issues).
src/Libraries/RevitServices/RevitServices.csproj	Removes config-specific MSBuild groups; excludes threading code for _DA builds.
src/Libraries/RevitServices/Properties/AssemblyInfo.cs	Expands InternalsVisibleTo to enable DA and other assemblies to access internals.
src/Libraries/RevitServices/Persistence/DocumentManager.cs	Adds DA-friendly CurrentDBDocument handling and PrepareForDesignAutomation.
src/Libraries/RevitServices/Events/EventHandlerProxy.cs	Adds singleton instance + DA compilation guards for UI view events.
src/Libraries/RevitNodesUI/SunPath.cs	Switches to RevitServices event proxy and avoids UI events in DA builds.
src/Libraries/RevitNodesUI/SiteLocation.cs	Moves node view customization behind DA guard; switches to RevitServices event proxy.
src/Libraries/RevitNodesUI/Selection.cs	Switches document-open handling to RevitServices event proxy.
src/Libraries/RevitNodesUI/RevitTypes.cs	Cleans up unused usings at file top.
src/Libraries/RevitNodesUI/RevitNodesUI.csproj	Adds _DA build exclusions for UI controls/pages; restructures project file (now has duplicate refs).
src/Libraries/RevitNodesUI/RevitDropDown.cs	Switches document-open handling to RevitServices event proxy.
src/Libraries/RevitNodesUI/Elements.cs	Guards view-activated subscription for DA; switches to RevitServices event proxy.
src/Libraries/RevitNodes/Transaction/Transaction.cs	Avoids UIDocument.RefreshActiveView() for DA builds.
src/Libraries/RevitNodes/RevitNodes.csproj	Removes config-specific MSBuild property groups.
src/Libraries/RevitNodes/Properties/AssemblyInfo.cs	Adds InternalsVisibleTo("DADynamoApp").
src/Libraries/RevitNodes/Elements/Views/View.cs	Guards UI view-close logic for DA builds.
src/Libraries/RevitNodes/Elements/Views/StructuralPlanView.cs	Uses CurrentDBDocument.Application instead of UI application for structure check.
src/Libraries/RevitNodes/Elements/Views/Sheet.cs	Guards UI view-close logic for DA builds.
src/Libraries/RevitNodes/Elements/LinkElement.cs	Guards UI-only zoom helper for DA builds; minor formatting cleanup.
src/Libraries/RevitNodes/Elements/Element.cs	Guards UI-only view-close logic; uses DB ActiveView for overrides in DA context.
src/Libraries/RevitNodes/Elements/AdaptiveComponent.cs	Uses CurrentDBDocument.Application.Create instead of UI application.
src/Libraries/Migrations/Migrations.csproj	Removes config-specific MSBuild property groups.
src/DynamoRevitIcons/DynamoRevitIcons.csproj	Removes config-specific MSBuild property groups.
src/DynamoRevit/Utilities/internal class DynamoRevitAssemblyResolver.cs	New centralized assembly resolver (file path/name is problematic).
src/DynamoRevit/Utilities/DynamoRevitInternalNodes.cs	Extracts internal package discovery/parsing from DynamoRevit.cs.
src/DynamoRevit/Utilities/ASMPreloader.cs	Extracts ASM/libG preload + geometry factory path reflection helpers.
src/DynamoRevit/Properties/AssemblyInfo.cs	Adds InternalsVisibleTo("DADynamoApp").
src/DynamoRevit/Models/RevitDynamoModel.cs	Adds DA compilation guards; switches some active-view checks to DB document; switches to RevitServices proxy singleton.
src/DynamoRevit/DynamoRevitApp.cs	Refactors event proxy usage and assembly resolving (currently introduces compile issues).
src/DynamoRevit/DynamoRevit.csproj	Adds explicit core assembly references; adds _DA-specific compile removals; adjusts copy paths.
src/DynamoRevit/DynamoRevit.cs	Uses extracted ASM preloader + internal nodes helpers; fixes RevitPathResolver argument usage.
src/DynamoRevit.DA.sln	Adds a dedicated solution for DA build profile.
src/DynamoRevit.All.sln	Adds additional project dependency entry.
src/DADynamoApp/SetupDARequest.cs	Adds DA setup request model types (local/cloud inputs and save options).
src/DADynamoApp/DARunGraphController.cs	Adds DA-specific controller wrapper for graph execution routing.
src/DADynamoApp/DALogger.cs	Adds stdout-based logger with node output serialization/profiling support.
src/DADynamoApp/DAEntrypoint.cs	Adds the DA external app entrypoint: model setup, handler wiring, python deps preinstall, run execution, save behavior.
src/DADynamoApp/DADynamoApp.csproj	New DA app project definition and dependencies.
src/Config/CS_SDK.props	Adds NET10_DA platform/TFM and DESIGN_AUTOMATION constant for _DA builds; adjusts project reference metadata.
src/BUILDSYSTEM_TODO.md	Documents open build-system questions and known issues for net10/DA builds.
src/AssemblySharedInfoGenerator/AssemblyInfoGenerator.csproj	Adjusts DebugSymbols/OutputPath settings (now duplicated).

Comments suppressed due to low confidence (1)

src/Libraries/RevitNodesUI/RevitNodesUI.csproj:67

• RevitNodesUI.csproj includes the same three ProjectReferences twice (once without metadata, then again with <Private>False</Private>). This redundancy can lead to confusing MSBuild item state and makes it unclear which metadata is intended. Keep a single ItemGroup for these references and apply the desired metadata there.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

DynamoRevitApp defines a static property named EventHandlerProxy, and the getter currently references EventHandlerProxy.Instance, which resolves to the property name (not the RevitServices.EventHandler.EventHandlerProxy type) and will not compile. Use the fully-qualified type name in the getter (or rename the property) so the reference is unambiguous.

Suggested change

	get { return EventHandlerProxy.Instance; }
	get { return RevitServices.EventHandler.EventHandlerProxy.Instance; }

[Copilot]

EventHandlerProxy.Instance = null; will not compile (and even if it did, clearing a singleton instance like this is unsafe for any other subscribers that still hold references). Instead, keep the singleton instance alive and only unsubscribe the individual Revit application events (or add an explicit Dispose/ClearSubscribers method on the proxy if you truly need to drop handlers).

[Copilot]

Process is used here but System.Diagnostics is not imported, and it is not part of the SDK implicit usings set for Microsoft.NET.Sdk. Add using System.Diagnostics; (or fully-qualify System.Diagnostics.Process) to avoid a compile error.

[Copilot]

[Route] and [FromBody] attributes are used without any using for their defining namespace. Unless these are custom attributes re-exported by DynamoPlayer, this will not compile. Add the appropriate reference/using (typically Microsoft.AspNetCore.Mvc) or fully-qualify the attribute types.

[Copilot]

SubscribeApplicationEvents/UnsubscribeApplicationEvents reference EventHandlerProxy.Instance..., but EventHandlerProxy is also the name of the static property on DynamoRevitApp. Inside this class that name resolves to the property, so .Instance won’t compile. Use the fully-qualified type name (e.g. RevitServices.EventHandler.EventHandlerProxy.Instance) or rename the DynamoRevitApp.EventHandlerProxy property to avoid the identifier collision.

[Copilot]

This property group now sets DebugSymbols and OutputPath twice (lines 12 vs 14, and 13 vs 17). The earlier values will be overridden, which is easy to miss when editing build settings. Remove the duplicates and keep a single authoritative value for each property.

[Copilot]

EventHandlerProxy.Instance is declared internal, but it is referenced from multiple other assemblies in this PR (e.g. DynamoRevit, RevitNodesUI, tests). As written, this will cause accessibility errors. Expose the singleton via a public static property/field (e.g. public static EventHandlerProxy Instance { get; } = new();) or add the necessary InternalsVisibleTo entries for every consuming assembly.

[Copilot]

This test calls entrypoint.SetupProfilingHandlers(Model), but SetupProfilingHandlers is private in DAEntrypoint, so the test will not compile. Either make SetupProfilingHandlers internal/public (and add InternalsVisibleTo for RevitSystemTests if needed) or adjust the test to exercise the behavior through a public entrypoint.

[Copilot]

This file is added under a path that includes spaces (Utilities/internal class DynamoRevitAssemblyResolver.cs) and the type is declared in the global namespace. Both make discovery, tooling, and future refactors harder (and the filename is likely unintentional). Rename the file to Utilities/DynamoRevitAssemblyResolver.cs and place the type under an appropriate namespace (e.g. Dynamo.Applications.Utilities).

Suggested change

	internal class DynamoRevitAssemblyResolver
	{
	/// <summary>
	/// Handler to the ApplicationDomain's AssemblyResolve event.
	/// If an assembly's location cannot be resolved, an exception is
	/// thrown. Failure to resolve an assembly will leave Dynamo in
	/// a bad state, so we should throw an exception here which gets caught
	/// by our unhandled exception handler and presents the crash dialogue.
	/// </summary>
	/// <param name="dynamoCorePath"></param>
	/// <param name="args"></param>
	/// <returns></returns>
	internal static Assembly ResolveDynamoAssembly(string dynamoCorePath, List<string> additionalPaths, ResolveEventArgs args)
	{
	var assemblyPath = string.Empty;
	var assemblyName = new AssemblyName(args.Name).Name + ".dll";
	try
	{
	assemblyPath = Path.Combine(dynamoCorePath, assemblyName);
	if (File.Exists(assemblyPath))
	{
	return Assembly.LoadFrom(assemblyPath);
	}
	if (additionalPaths != null)
	{
	foreach (var additionalPath in additionalPaths)
	{
	assemblyPath = Path.Combine(additionalPath, assemblyName);
	if (File.Exists(assemblyPath))
	{
	return Assembly.LoadFrom(assemblyPath);
	}
	}
	}
	var assemblyLocation = Assembly.GetExecutingAssembly().Location;
	var assemblyDirectory = Path.GetDirectoryName(assemblyLocation);
	// Try "Dynamo 0.x\Revit_20xx" folder first...
	assemblyPath = Path.Combine(assemblyDirectory, assemblyName);
	if (!File.Exists(assemblyPath))
	{
	// If assembly cannot be found, try in "Dynamo 0.x" folder.
	var parentDirectory = Directory.GetParent(assemblyDirectory);
	assemblyPath = Path.Combine(parentDirectory.FullName, assemblyName);
	}
	return (File.Exists(assemblyPath) ? Assembly.LoadFrom(assemblyPath) : null);
	}
	catch (Exception ex)
	{
	Console.WriteLine(ex.Message + ex.StackTrace);
	throw new Exception(string.Format("The location of the assembly, {0} could not be resolved for loading.", assemblyPath), ex);
	}
	namespace Dynamo.Applications.Utilities
	{
	internal class DynamoRevitAssemblyResolver
	{
	/// <summary>
	/// Handler to the ApplicationDomain's AssemblyResolve event.
	/// If an assembly's location cannot be resolved, an exception is
	/// thrown. Failure to resolve an assembly will leave Dynamo in
	/// a bad state, so we should throw an exception here which gets caught
	/// by our unhandled exception handler and presents the crash dialogue.
	/// </summary>
	/// <param name="dynamoCorePath"></param>
	/// <param name="args"></param>
	/// <returns></returns>
	internal static Assembly ResolveDynamoAssembly(string dynamoCorePath, List<string> additionalPaths, ResolveEventArgs args)
	{
	var assemblyPath = string.Empty;
	var assemblyName = new AssemblyName(args.Name).Name + ".dll";
	try
	{
	assemblyPath = Path.Combine(dynamoCorePath, assemblyName);
	if (File.Exists(assemblyPath))
	{
	return Assembly.LoadFrom(assemblyPath);
	}
	if (additionalPaths != null)
	{
	foreach (var additionalPath in additionalPaths)
	{
	assemblyPath = Path.Combine(additionalPath, assemblyName);
	if (File.Exists(assemblyPath))
	{
	return Assembly.LoadFrom(assemblyPath);
	}
	}
	}
	var assemblyLocation = Assembly.GetExecutingAssembly().Location;
	var assemblyDirectory = Path.GetDirectoryName(assemblyLocation);
	// Try "Dynamo 0.x\Revit_20xx" folder first...
	assemblyPath = Path.Combine(assemblyDirectory, assemblyName);
	if (!File.Exists(assemblyPath))
	{
	// If assembly cannot be found, try in "Dynamo 0.x" folder.
	var parentDirectory = Directory.GetParent(assemblyDirectory);
	assemblyPath = Path.Combine(parentDirectory.FullName, assemblyName);
	}
	return (File.Exists(assemblyPath) ? Assembly.LoadFrom(assemblyPath) : null);
	}
	catch (Exception ex)
	{
	Console.WriteLine(ex.Message + ex.StackTrace);
	throw new Exception(string.Format("The location of the assembly, {0} could not be resolved for loading.", assemblyPath), ex);
	}
	}

[Copilot]

The utility class name ASMPrealoaderUtils looks misspelled ("Prealoader" vs "Preloader"). Since this is a newly introduced type referenced across the PR, consider renaming it (and the file) to ASMPreloaderUtils for clarity and consistency.

Suggested change

	internal static class ASMPrealoaderUtils
	internal static class ASMPreloaderUtils

[pinzart90]

@pinzart90 are you looking for a review on this or just getting it spun up?

I don't think it is review-able yet