Skip to content

REVIT-220855: D4R CI/CD improvements — AssemblySharedInfo.tt is the version source of truth#3310

Open
Fusneica-FlorentinCristian wants to merge 3 commits into
masterfrom
fusneif/REVIT-220855/improvements-to-ci-cd-dynamo-for-revit-pipeline
Open

REVIT-220855: D4R CI/CD improvements — AssemblySharedInfo.tt is the version source of truth#3310
Fusneica-FlorentinCristian wants to merge 3 commits into
masterfrom
fusneif/REVIT-220855/improvements-to-ci-cd-dynamo-for-revit-pipeline

Conversation

@Fusneica-FlorentinCristian
Copy link
Copy Markdown
Collaborator

@Fusneica-FlorentinCristian Fusneica-FlorentinCristian commented Apr 6, 2026

REVIT-220855: DynamoRevit — version source of truth reference

Status: No code changes in this repo

This PR is a tracking reference only. All CI/CD pipeline changes are in the build repos:

  • DynamoRevitUtils (PR #123): Refactored pipeline reads version from AssemblySharedInfo.tt, adds CONTENT_ONLY support, extracts helpers
  • dynamo-steel-connection-automation (PR #340): Same pattern for SC4D pipeline

Versioning Strategy (applies to both pipelines)

src/AssemblySharedInfoGenerator/AssemblySharedInfo.tt is the single source of truth for DLL binary versions. The CI/CD pipelines READ from this file — they never modify it.

Build Type D4R Deploy Version SC4D NuGet Version
Binary change Major.Minor.Build (e.g., 28.0.0) Major.Minor.Build.0 (e.g., 28.0.0.0)
Content-only Major.Minor.Build-BUILD_NUMBER (e.g., 28.0.0-42) Major.Minor.Build.BUILD_NUMBER (e.g., 28.0.0.823)

How to bump versions

When shipping binary changes, update the values in AssemblySharedInfo.tt:

int MajorVersion = 28;
int MinorVersion = 0;
int BuildNumber = 0;  // ← increment this for binary releases

The pipelines will automatically pick up the new values on the next build.

…ontent-only build counter

Update AssemblySharedInfo.tt in both repos to hold product version numbers
(D4R: 0.8.3, SC4D: 7.0.1) instead of the Revit-year-based 28.0.0.

Add CONTENT_ONLY build parameter to Jenkinsfile in D4RUtils and SC4D:
- false (default): package version matches binary version from AssemblySharedInfo.tt
  (D4R: Major.Minor.Patch, SC4D: Major.Minor.Patch.0)
- true: BUILD_NUMBER appended as a counter for content-only deploys
  (D4R: Major.Minor.Patch-N, SC4D: Major.Minor.Patch.N)

Remove hardcoded version strings; AssemblySharedInfo.tt is now the single
source of truth for both DLL assembly versions and package versions.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the version source-of-truth used by the AssemblySharedInfo T4 template so that the product/package version (0.8.3) is aligned with the generated assembly version components, supporting CI/CD version correlation for Dynamo for Revit.

Changes:

  • Updated MajorVersion, MinorVersion, and BuildNumber in AssemblySharedInfo.tt from the Revit-year-based 28.0.0 to product version 0.8.3.
  • Keeps assembly AssemblyVersion/AssemblyFileVersion generation driven by the same template-defined version fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@Mikhinja Mikhinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should be the other way around, the package build should be changed to follow this, do not change this version to match package version

@Fusneica-FlorentinCristian Fusneica-FlorentinCristian changed the title REVIT-220855: correlate package version with AssemblySharedInfo.tt, content-only build counter REVIT-220855: D4R CI/CD improvements — read version from AssemblySharedInfo.tt, add CONTENT_ONLY build counter Apr 7, 2026
@Fusneica-FlorentinCristian Fusneica-FlorentinCristian changed the title REVIT-220855: D4R CI/CD improvements — read version from AssemblySharedInfo.tt, add CONTENT_ONLY build counter REVIT-220855: D4R CI/CD improvements — AssemblySharedInfo.tt is the version source of truth May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants