fix(typing): support (Interaction) -> Any as type in @cooldown - #1567
Open
Enegg wants to merge 3 commits into
Open
fix(typing): support (Interaction) -> Any as type in @cooldown#1567Enegg wants to merge 3 commits into
(Interaction) -> Any as type in @cooldown#1567Enegg wants to merge 3 commits into
Conversation
Enegg
commented
Jul 11, 2026
shiftinv
added
t: refactor/typing/lint
shiftinv
reviewed
Jul 11, 2026
Enegg
force-pushed
the
fix-cooldowns-typings
branch
from
July 30, 2026 19:22
6188f92 to
99c0161
Compare
shiftinv
reviewed
Jul 31, 2026
| self._factory: Callable[[Message], Cooldown] = factory | ||
| self._factory: Callable[[ContextTypeT], Cooldown] = factory | ||
|
|
||
| def copy(self) -> DynamicCooldownMapping: |
Member
There was a problem hiding this comment.
Suggested change
| def copy(self) -> DynamicCooldownMapping: | |
| def copy(self) -> DynamicCooldownMapping[ContextTypeT]: |
| self._type: Callable[[Message], Any] = type | ||
| self._type: Callable[[ContextTypeT], Any] = type | ||
|
|
||
| def copy(self) -> CooldownMapping: |
Member
There was a problem hiding this comment.
Suggested change
| def copy(self) -> CooldownMapping: | |
| def copy(self) -> CooldownMapping[ContextTypeT]: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes typings of
disnake.ext.commands.{cooldowns,core,base_core}to properly support Interactions (and Context).Checklist
uv run nox -s lintuv run nox -s pyright