Skip to content

fix(commands): some caveats related to guild cache in user app interactions - #1262

Merged
shiftinv merged 4 commits into
masterfrom
fix/user-app-caveats
Dec 28, 2024
Merged

fix(commands): some caveats related to guild cache in user app interactions#1262
shiftinv merged 4 commits into
masterfrom
fix/user-app-caveats

Conversation

@shiftinv

@shiftinv shiftinv commented Dec 25, 2024

Copy link
Copy Markdown
Member

Summary

The other remaining part of #1173.
This adds a small note to Interaction.member, explaining why role-related fields might not work in certain situations. This was already more or less present on Interaction.guild, but the internal relationship between those isn't immediately obvious.
Also makes the @commands.dm_only and @commands.guild_only checks work properly in all cases by using guild_id instead of guild for interactions, additionally adding a note linking to the better alternative (ie contexts).

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples t: bugfix skip news labels Dec 25, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Dec 25, 2024
@shiftinv
shiftinv merged commit 14d5b78 into master Dec 28, 2024
@shiftinv
shiftinv deleted the fix/user-app-caveats branch December 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news t: bugfix t: documentation Improvements or additions to documentation/examples

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant