Added conditions for branched services#214
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 95.31% 95.10% -0.22%
==========================================
Files 10 10
Lines 854 858 +4
==========================================
+ Hits 814 816 +2
- Misses 40 42 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Are you able to add a test-case for this new logic please? |
274a7e9 to
927faba
Compare
|
Please could you add some info of how branched beamlines should be structured moving forward? e.g. BL15I-synoptic and BL15J-synoptic or does everything get put inside synoptic etc? |
|
@niamhdougan , sorry, I am just now seeing this. Basically, I based it off the current i15-services repository. Currently, in i15-services, there exists a services directory where the services could either be bl15j, or bl15i. So I have based the screen generation and validation on the difference in the synoptic directory, where the techui.yaml file, could either be a bl15i, or bl15j, or k yaml ( it's contents i.e, beamline, location, e.t.c.) file. Based off what the techui-yaml file says, it looks for the corresponding services in the services folder. So basically, there will be one i15-services, but for each branch beamline, there will be seperate techui.yaml files. It will be named synoptic but the techui.yaml file will change, we can also keep multiple techui.yaml files in the same synoptic directory, as we reference the chosen one when building the screens. |
927faba to
7ac9eac
Compare
Added support for multiple synoptic beamlines.