Skip to content

Added conditions for branched services#214

Draft
adedamola-sode wants to merge 3 commits into
mainfrom
multiple-beamlines-one-service
Draft

Added conditions for branched services#214
adedamola-sode wants to merge 3 commits into
mainfrom
multiple-beamlines-one-service

Conversation

@adedamola-sode
Copy link
Copy Markdown
Collaborator

Added support for multiple synoptic beamlines.

  • Added conditional in find-dirs in main.py to handle branches that start with j/k
  • Changed synoptic_dir to be abs_path.parent

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.10%. Comparing base (49cabfa) to head (7ac9eac).

Files with missing lines Patch % Lines
src/techui_builder/__main__.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   95.31%   95.10%   -0.22%     
==========================================
  Files          10       10              
  Lines         854      858       +4     
==========================================
+ Hits          814      816       +2     
- Misses         40       42       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/techui_builder/__main__.py Outdated
Comment thread src/techui_builder/__main__.py
@OCopping
Copy link
Copy Markdown
Collaborator

OCopping commented May 5, 2026

Are you able to add a test-case for this new logic please?

@adedamola-sode adedamola-sode force-pushed the multiple-beamlines-one-service branch from 274a7e9 to 927faba Compare May 8, 2026 06:47
@niamhdougan
Copy link
Copy Markdown
Collaborator

Please could you add some info of how branched beamlines should be structured moving forward? e.g. BL15I-synoptic and BL15J-synoptic or does everything get put inside synoptic etc?

@adedamola-sode
Copy link
Copy Markdown
Collaborator Author

adedamola-sode commented May 21, 2026

@niamhdougan , sorry, I am just now seeing this.

Basically, I based it off the current i15-services repository. Currently, in i15-services, there exists a services directory where the services could either be bl15j, or bl15i. So I have based the screen generation and validation on the difference in the synoptic directory, where the techui.yaml file, could either be a bl15i, or bl15j, or k yaml ( it's contents i.e, beamline, location, e.t.c.) file. Based off what the techui-yaml file says, it looks for the corresponding services in the services folder.

So basically, there will be one i15-services, but for each branch beamline, there will be seperate techui.yaml files. It will be named synoptic but the techui.yaml file will change, we can also keep multiple techui.yaml files in the same synoptic directory, as we reference the chosen one when building the screens.

@adedamola-sode adedamola-sode force-pushed the multiple-beamlines-one-service branch from 927faba to 7ac9eac Compare May 22, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants