adding a barrier after output folder creation#719
Merged
Conversation
yousefmoazzam
approved these changes
May 20, 2026
Collaborator
yousefmoazzam
left a comment
There was a problem hiding this comment.
As mentioned in the team meeting, I think that adding a barrier is the correct way to resolve the race condition of the non-zero rank processes seeing the YAML file at all, or seeing the YAML file in the correct state.
Just needs the linting fixed and this is good to go, thanks! 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue of not having the output folder created for other ranks than 0.
I went the
global_comm.Barrier()way as at this point in the run there shouldn't be much of racing going on and we're not loosing time on synchronisation? It fixes the problem in Jenkins tests and pipelines run.Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes