Add Mbs driver and region classes#2056
Open
oliwenmandiamond wants to merge 23 commits into
Open
Conversation
…ss config for PV's
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
========================================
Coverage 99.12% 99.12%
========================================
Files 336 340 +4
Lines 13065 13198 +133
========================================
+ Hits 12951 13083 +132
- Misses 114 115 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2068. This implements the
MbsRegionandMbsAnalyserDriverIOusing the base electron analyser classes. This has updated the testing framework to be much more flexible, allowing for sequence files to be loaded directly to given regions to tests and paired with other fixtures (e.g associated detector and driver) without needing the files to have same number and named regions.Note: I have removed the image and spectrum pv's from base (for now). This is because Mbs does not use the spectrum like Specs and VGScienta does. I also don't think they are needed from speaking with controls and understanding how the HDF file writer plugin works and will be next bit of work to do once this is complete.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}