Skip to content

Mx bluesky 1354 scintillator safe move #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rtuck99 wants to merge 18 commits into
base: main
Choose a base branch
from

Fixup unit tests

a2e9c3f
Select commit
Loading
Failed to load commit list.
Draft

Mx bluesky 1354 scintillator safe move #1819

Fixup unit tests
a2e9c3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 5, 2026 in 0s

99.12% (-0.03%) compared to 07c1416

View this Pull Request on Codecov

99.12% (-0.03%) compared to 07c1416

Details

Codecov Report

❌ Patch coverage is 97.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.12%. Comparing base (07c1416) to head (a2e9c3f).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/dodal/devices/mx_phase1/scintillator.py 95.83% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
- Coverage   99.14%   99.12%   -0.03%     
==========================================
  Files         304      305       +1     
  Lines       11509    11571      +62     
==========================================
+ Hits        11411    11470      +59     
- Misses         98      101       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov