Skip to content

fix: Install debugpy in container instead of adding it #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tpoliaw wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −6
Open

fix: Install debugpy in container instead of adding it #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f76bde
fix: Install debugpy in container instead of adding it
tpoliaw Apr 29, 2026
9266c8a
Add test for docker version number
tpoliaw May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/_container.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ jobs:
load: true
tags: tag_for_testing

- name: Test cli works in cached runtime image
run: docker run --rm tag_for_testing --version

- name: Create tags for publishing image
id: meta
uses: docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804 # v5
Expand All @@ -64,6 +61,20 @@ jobs:
type=ref,event=tag
type=raw,value=latest

- name: Test cli works in cached runtime image
id: app-version
run: |
APP_VERSION=$(docker run --rm tag_for_testing --version)
echo "Version in built container: $APP_VERSION"
echo "version=$APP_VERSION" >> "$GITHUB_OUTPUT"

- name: Check versions match
if: github.ref_type == 'tag'
run: '[[ "$APP_VERSION" = "blueapi, version $REPO_VERSION" ]]'
env:
APP_VERSION: ${{ steps.app-version.outputs.version }}
REPO_VERSION: ${{ steps.meta.outputs.version }}

- name: Push cached image to container registry
if: github.ref_type == 'tag'
uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ RUN apt-get update -y && apt-get install -y --no-install-recommends \
graphviz \
&& apt-get dist-clean

# Install helm for the dev container. This is the recommended
# Install helm for the dev container. This is the recommended
# approach per the docs: https://helm.sh/docs/intro/install
RUN curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3; \
chmod 700 get_helm.sh; \
Expand All @@ -27,12 +27,12 @@ RUN chmod o+wrX .
# Tell uv sync to install python in a known location so we can copy it out later
ENV UV_PYTHON_INSTALL_DIR=/python

RUN uv add debugpy

# Sync the project without its dev dependencies
RUN --mount=type=cache,target=/root/.cache/uv \
uv sync --locked --no-editable --no-dev --managed-python

RUN uv pip install debugpy

# The runtime stage copies the built venv into a runtime container
FROM ubuntu:resolute AS runtime

Expand Down
Loading