refactor: decompose screen_reachability updateConfig nested switch - #250
Conversation
Split the nested-switch updateConfig into focused helpers: configMaxField (manual-IP destinations expose an extra field), adjustConfigProtocol, deleteConfigChar, appendConfigChar (with the existing digit/IP charset validation), and submitConfig (advance from the protocol field, start analysis from input fields). Key handling behavior is unchanged and each piece now has direct unit tests. Closes DevopsArtFactory#205 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFhLrnpVxivu62cC3k9NZB
|
Warning Review limit reached
Next review available in: 5 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Recreated as #263 from an in-repo branch under the maintainer account; this PR is superseded. |
Summary
Implements #205:
updateConfiginscreen_reachability.gohandled field navigation, protocol selection, character input validation, and submission in one nested switch.configMaxField()(single source of truth for the manual-IP extra field),adjustConfigProtocol(),deleteConfigChar(),appendConfigChar()(digit/IP charset validation unchanged), andsubmitConfig()(advance from the protocol field, run analysis from input fields).maxFieldcomputation that appeared three times is gone.Testing
go test ./...passes; new unit tests cover max-field derivation, protocol clamping (including no-op off the protocol field), port/IP character validation with backspace, and enter-advance vs. analysis-start.make buildpasses.Closes #205