Skip to content

refactor: replace checklistRunner cache triples with a generic lazycache - #248

Closed
youngjinjung-linq wants to merge 1 commit into
DevopsArtFactory:mainfrom
youngjinjung-linq:refactor/issue-204-checklist-lazycache
Closed

refactor: replace checklistRunner cache triples with a generic lazycache#248
youngjinjung-linq wants to merge 1 commit into
DevopsArtFactory:mainfrom
youngjinjung-linq:refactor/issue-204-checklist-lazycache

Conversation

@youngjinjung-linq

Copy link
Copy Markdown

Summary

Implements #204: checklistRunner repeated the same xLoaded bool / xErr error / xBy... map pattern seven times (RDS, hosted zones, VPCs, subnets, log groups, security groups, secrets).

  • New lazyCache[T] memoizes a single fetch — first Get runs the fetch once, later Gets return the same value and error without refetching (including memoized failures, matching the old behavior).
  • Each resource group's maps move into a small index struct (vpcIndex, subnetIndex, …) built inside the fetch closure.
  • Lookup logic (ID/name/ARN resolution, ambiguity errors, VPC scoping) is unchanged; the subnet loader still composes on the VPC loader through the cache.
  • secretDetails and zoneRecords stay as plain per-key maps — they are keyed caches, not load-once lists.

Testing

  • go test ./... passes; existing checklist tests cover the resolution behavior, and a new test pins the lazyCache contract (fetch-once, memoized value, memoized error, no retry).
  • make build passes.

Closes #204

Replace the seven repeated loaded/err/data field triples in
checklistRunner with a generic lazyCache[T] that memoizes a single
fetch (value and error) plus small per-resource index structs. Lookup
behavior is unchanged; the runner struct drops from 21 cache fields to
7 typed caches, and new checklist resource types no longer need to
hand-roll the load-once pattern.

Closes DevopsArtFactory#204

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BFhLrnpVxivu62cC3k9NZB
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@youngjinjung-linq, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 18a67242-3019-4207-a805-b92ce693bc74

📥 Commits

Reviewing files that changed from the base of the PR and between 744b139 and ddc81a3.

📒 Files selected for processing (2)
  • internal/inspector/checklist.go
  • internal/inspector/checklist_lazycache_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@YoungJinJung

Copy link
Copy Markdown
Contributor

Recreated as #261 from an in-repo branch under the maintainer account; this PR is superseded.

@youngjinjung-linq
youngjinjung-linq deleted the refactor/issue-204-checklist-lazycache branch August 13, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: replace repeated loaded/err/data cache triples in checklistRunner with a generic lazycache

2 participants