Skip to content

getLegacyGitAccessor(): Don't ignore errors #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edolstra merged 1 commit into from
Apr 16, 2026
+14 −5
Merged

getLegacyGitAccessor(): Don't ignore errors #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/libfetchers/git.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,11 +834,20 @@ struct GitInputScheme : InputScheme
options.submodules
? [&]() {
// Nix < 2.20 used `git checkout` for repos with submodules.
runProgram({.program = "git", .args = {"init", tmpDir, "-b", "master"}});
runProgram({.program = "git", .args = {"-C", tmpDir, "remote", "add", "origin", repoDir}});
runProgram(
{.program = "git", .args = {"-C", tmpDir, "fetch", "--quiet", "origin", rev.gitRev()}});
runProgram({.program = "git", .args = {"-C", tmpDir, "checkout", "--quiet", rev.gitRev()}});
StringSink sink; // don't pollute stdout
runProgram2({.program = "git", .args = {"init", tmpDir, "-b", "master"}, .standardOut = &sink});
runProgram2(
{.program = "git",
.args = {"-C", tmpDir, "remote", "add", "origin", repoDir},
.standardOut = &sink});
runProgram2(
{.program = "git",
.args = {"-C", tmpDir, "fetch", "--quiet", "origin", rev.gitRev()},
.standardOut = &sink});
runProgram2(
{.program = "git",
.args = {"-C", tmpDir, "checkout", "--quiet", rev.gitRev()},
.standardOut = &sink});
PathFilter filter = [&](const Path & path) { return baseNameOf(path) != ".git"; };
return store.addToStore(
"source",
Expand Down
Loading