Update compiler target#181
Conversation
✅ Deploy Preview for detsys-ts-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughAdds a short DOCS.md and sets TypeDoc's readme to it; updates tsdown.config.ts TypeScript target from "node20" to "esnext". ChangesDocumentation and Build Setup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@DOCS.md`:
- Line 2: The markdown uses non-descriptive link text "[here][typedoc]" which
triggers MD059; replace the "here" link text with a descriptive phrase (e.g.,
"generated documentation" or "Typedoc documentation") while keeping the existing
reference label [typedoc], so the line becomes something like "Check out the
generated documentation [generated documentation][typedoc]" (use a concise,
descriptive label that conveys the destination).
In `@tsdown.config.ts`:
- Line 7: The tsdown configuration sets an unsupported target "es2026"; update
the target property in tsdown.config.ts (the target: "es2026" entry) to a
supported value such as "es2023" or "esnext" so the build uses a valid
ECMAScript target and avoids transpilation errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 905c5c19-8cce-41f8-bbc4-243be32c1e66
📒 Files selected for processing (3)
DOCS.mdtsdown.config.tstypedoc.config.cjs
cole-h
left a comment
There was a problem hiding this comment.
Please don't forget to merge all the PRs against all the actions that this is going to spawn 🙏
There was a problem hiding this comment.
Not sure the point of this when we already have a README.md, but it doesn't really matter 🤷
Description
This doesn't actually change the generated JS payload but this is something we should be doing anyway.
I also fixed a funny issue where this was showing up in the docs:
Checklist
Summary by CodeRabbit
Documentation
Chores