test(#4553): skip Gemini live smoke test on geo-block, not just rate limit#221
Merged
Conversation
…limit GeminiClientIntegrationTest reddened local builds with "FAILED_PRECONDITION: User location is not supported for the API use" — a Gemini API geo-block keyed on the runner's IP region, not a code defect. The skip helper only caught RESOURCE_EXHAUSTED / 429, so geo-blocked environments failed instead of skipping (CI is unaffected — no key there, so the test already self-skips). Renamed skipIfRateLimited -> skipIfEnvironmental and broadened it to also abort/skip on FAILED_PRECONDITION + "location is not supported", matching the rate-limit posture. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A live
GeminiClientIntegrationTestrun reddened a local build withLlmProviderException: FAILED_PRECONDITION: User location is not supported for the API use— a Gemini API geo-block keyed on the runner's IP region, not a code defect. The skip helper only caughtRESOURCE_EXHAUSTED/429, so geo-blocked environments failed instead of skipping.(CI is unaffected — no Gemini key there, so the test already self-skips; this only bit local builds with a key present in a blocked region.)
Change
Renamed
skipIfRateLimited→skipIfEnvironmentaland broadened it to alsoabort(skip) onFAILED_PRECONDITION+"location is not supported", matching the existing rate-limit posture. Test-only.Full
./gradlew buildgreen.🤖 Generated with Claude Code