Fix inverted success/failure logic in evaluate.js - #127
Open
sirbleek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
Problem: evaluate_js in css_browserhook.py does not check exceptionDetails in the DevTools Runtime.evaluate response. When JavaScript throws an exception, the code falls through to res = None. In commit_css_transaction, if res is None: return res treats this as success. Meanwhile, successful execution returns "Undefined" (a string), which triggers the retry loop as a failure. Success and failure are completely inverted.
Result: CSS injection silently fails on every attempt. Logs show “Committing css transaction” with no errors, but nothing renders in the Steam UI.
Fix: Change res = "Undefined" to res = None so successful execution correctly signals success to commit_css_transaction.
Tested on: SteamOS 3.7.25, Decky v3.2.3, CSS Loader 2.1.2