POLAR@3: Introduce interaction masking via core for routing - #873
Open
oeninghe-dataport wants to merge 6 commits into
Open
POLAR@3: Introduce interaction masking via core for routing#873oeninghe-dataport wants to merge 6 commits into
oeninghe-dataport wants to merge 6 commits into
Conversation
oeninghe-dataport
requested review from
czirkelbach,
raschju and
warm-coolguy
as code owners
July 10, 2026 16:47
|
dopenguin
force-pushed
the
vue3/migrate-plugin-routing
branch
from
July 13, 2026 08:39
dba4ddd to
bb8948e
Compare
dopenguin
force-pushed
the
vue3/routing-with-interaction-masking
branch
2 times, most recently
from
July 14, 2026 20:22
91c741e to
ce3404b
Compare
dopenguin
added
enhancement
dopenguin
force-pushed
the
vue3/routing-with-interaction-masking
branch
from
July 14, 2026 20:33
497b9e6 to
ce3404b
Compare
dopenguin
force-pushed
the
vue3/routing-with-interaction-masking
branch
from
July 15, 2026 10:53
ce3404b to
a481dd8
Compare
dopenguin
force-pushed
the
vue3/routing-with-interaction-masking
branch
from
July 15, 2026 13:54
a481dd8 to
0254104
Compare
oeninghe-dataport
force-pushed
the
next
branch
2 times, most recently
from
July 17, 2026 08:49
a353df3 to
6a19ea0
Compare
dopenguin
requested changes
Jul 20, 2026
|
|
||
| /** | ||
| * Masks an interaction for a plugin. | ||
| * If the interaction is already masked by another plugin, an error is thrown. |
Member
There was a problem hiding this comment.
So, if I start the draw plugin and want to draw a polygon, then decide that I want to instead find a route but forget to turn of the draw plugin - maskInteraction fails in routing with an error but the user does not receive an information about that. That doesn't really seem the way to go.
This can currently be tested if one removes the if-statement in maskInteraction and then clicking on one of the input-fields of the routing plugin.
Collaborator
Author
There was a problem hiding this comment.
The expected behaviour is that I can activate the next plugin s.t. the previous is deactivated then. This is implemented w/ 5fb2060
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #842 (comment)
Blocked by #842