Allow removal and adding for plugins in iconMenu by oeninghe-dataport · Pull Request #861 · Dataport/polar

oeninghe-dataport · 2026-07-06T08:38:58Z

Summary

Plugins in iconMenu can be added and removed at runtime.

Note:
coreStore.removePlugin(...) is still not supported for plugins within iconMenu. I deem this correct. As iconMenu adds the plugin, it should also be responsible for removal of the plugin. Otherwise, we'd need to breach the separation of core and plugins.

Instructions for local reproduction and review

Open snowbox.
Add the layer "Anliegen (MML)"
Open filter plugin.
Filter out some "Anliegen".
Press the newly-introduced "Add/Remove filter plugin" button.

Relevant tickets, issues, et cetera

Fixes #668

github-actions · 2026-07-06T08:41:24Z

PR Preview Action v1.8.1
🚀 View preview at https://Dataport.github.io/polar/pr-preview/pr-861/
Built to branch `gh-pages` at 2026-07-29 18:05 UTC. Preview will be ready when the GitHub Pages deployment is complete.

dopenguin

🏓 @oeninghe-dataport

oeninghe-dataport · 2026-07-07T12:02:12Z

🏓 @dopenguin

dopenguin · 2026-07-07T16:32:01Z

🏓 @dopenguin

🏓 @oeninghe-dataport

As decided in a not-yet-published architectural decision, we usually do not want to use watchers, but explicit mutations instead :-(

oeninghe-dataport · 2026-07-29T18:04:23Z

🏓 @dopenguin

dopenguin

Quite a lot of actions seem to fire when removing the plugin 🤨

🏓 @oeninghe-dataport

dopenguin · 2026-07-31T14:47:11Z

These functions are not in use. Please remove them.

dopenguin · 2026-07-31T14:50:02Z

 	if (open.value === props.id) {
-		open.value = null
-		useCoreStore().setMoveHandle(null)
+		iconMenuStore.openMenuById(null)
 	} else {
-		open.value = props.id
-		iconMenuStore.openInMoveHandle(props.id)
+		iconMenuStore.openMenuById(props.id)
 	}


Might as well just call iconMenuStore.openMenuById(open.value === props.id ? null : props.id)

dopenguin · 2026-07-31T14:52:17Z

 	if (open.value === id) {
-		open.value = null
-		coreStore.setMoveHandle(null)
+		iconMenuStore.openMenuById(null)
 	} else {
-		open.value = id
-		iconMenuStore.openInMoveHandle(id)
+		iconMenuStore.openMenuById(id)
 	}


Might as well just call iconMenuStore.openMenuById(open.value === id ? null : id)

dopenguin · 2026-07-31T14:58:18Z

+		 *
+		 * To change the open menu, use {@link openMenuById}.
+		 *
+		 * @readonly


Suggested change

* @readonly

* @readonly

* @alpha

dopenguin · 2026-07-31T14:58:27Z

+		 *
+		 * To change the open focus menu, use {@link openFocusMenuById}.
+		 *
+		 * @readonly


Suggested change

* @readonly

* @readonly

* @alpha

dopenguin · 2026-07-31T14:58:42Z

+		/**
+		 * Appends a group of plugins to the icon menu.
+		 *
+		 * @param menu - The menu item group to add.


Suggested change

* @param menu - The menu item group to add.

* @param menu - The menu item group to add.

* @alpha

dopenguin · 2026-07-31T14:58:56Z

+		/**
+		 * Appends a plugin to the icon menu as a focus menu.
+		 *
+		 * @param menu - The focus menu item to add.


Suggested change

* @param menu - The focus menu item to add.

* @param menu - The focus menu item to add.

* @alpha

dopenguin · 2026-07-31T14:59:03Z

+		/**
+		 * Removes a plugin from the icon menu.
+		 *
+		 * @param pluginId - The ID of the plugin to remove.


Suggested change

* @param pluginId - The ID of the plugin to remove.

* @param pluginId - The ID of the plugin to remove.

* @alpha

dopenguin · 2026-07-31T15:08:29Z

+		)
+		filteredMenuGroup.forEach(({ plugin }) => {
+			if (plugin.component) {
+				markRaw(plugin.component)


It was previously more defensive with an additional toRaw. I feel like this should be readded here and in addFocusPlugin

dopenguin · 2026-07-31T15:10:48Z

+	function isPluginInIconMenu(pluginId: string) {
+		const display = coreStore.configuration[pluginId]?.displayComponent
+		return typeof display === 'boolean' ? display : true
+	}


This is not related to the intention of this PR thus 🎩, but I realized that this never did anything if the configuration was directly added to the plugin. If you see a quick solution, add it here, otherwise, I'll make a note for myself.

oeninghe-dataport added 3 commits July 6, 2026 10:31

feat(iconMenu): menus should be mutable

e14ded9

test(snowbox): allow removal and live insertion of iconMenu plugins

8f36876

fix(filter): reset filter state on plugin removal

4888d29

oeninghe-dataport added this to the POLAR@3 milestone Jul 6, 2026

oeninghe-dataport self-assigned this Jul 6, 2026

oeninghe-dataport requested a review from a team July 6, 2026 08:38

oeninghe-dataport requested review from czirkelbach, dopenguin, raschju and warm-coolguy as code owners July 6, 2026 08:38

oeninghe-dataport added the bug Something isn't working label Jul 6, 2026

oeninghe-dataport linked an issue Jul 6, 2026 that may be closed by this pull request

Plugins added by IconMenu can not be removed with "removePlugin" #668

Open

dopenguin requested changes Jul 6, 2026

View reviewed changes

Comment thread src/plugins/filter/store.ts

Comment thread src/plugins/iconMenu/store.ts Outdated

Comment thread src/plugins/iconMenu/store.ts Outdated

Comment thread src/plugins/iconMenu/store.ts Outdated

oeninghe-dataport force-pushed the next branch 2 times, most recently from a353df3 to 6a19ea0 Compare July 17, 2026 08:49

oeninghe-dataport added 6 commits July 29, 2026 16:50

Merge branch 'next' into fix/668-iconMenu-plugin-removal

866b395

refactor(iconMenu): extract lib function watchArray

d7e23ae

feat(iconMenu): allow adding and removal of plugins

b47d6cf

refactor(iconMenu): replace watcher with explicit mutations

28a8ef6

As decided in a not-yet-published architectural decision, we usually do not want to use watchers, but explicit mutations instead :-(

test(snowbox): adapt new iconMenu modification

bb128d2

refactor(iconMenu): replace open/focusOpen watcher with mutations

1d136e7

As decided in a not-yet-published architectural decision, we usually do not want to use watchers, but explicit mutations instead :-(

dopenguin requested changes Jul 31, 2026

View reviewed changes

	* @param menu - The menu item group to add.
	* @param menu - The menu item group to add.
	* @alpha

	* @param menu - The focus menu item to add.
	* @param menu - The focus menu item to add.
	* @alpha

	* @param pluginId - The ID of the plugin to remove.
	* @param pluginId - The ID of the plugin to remove.
	* @alpha

Uh oh!

Conversation

oeninghe-dataport commented Jul 6, 2026

Summary

Instructions for local reproduction and review

Relevant tickets, issues, et cetera

Uh oh!

github-actions Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-07-29 18:05 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

dopenguin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oeninghe-dataport commented Jul 7, 2026

Uh oh!

dopenguin commented Jul 7, 2026

Uh oh!

oeninghe-dataport commented Jul 29, 2026

Uh oh!

dopenguin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jul 6, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-07-29 18:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.