POLAR@3: Add nominatim support - #606
Conversation
52c8b35 to
4304863
Compare
oeninghe-dataport
changed the title
|
4304863 to
599e195
Compare
599e195 to
9757271
Compare
|
@oeninghe-dataport Please update the PR. Will review afterwards |
Some changes need to be evaluated after the merges of #447, #542 and #606 as they differ from those PRs and are just added here for type and linting fixes. # Conflicts: # .gitignore # examples/github-io/components/HeroPolarMap.vue # examples/snowbox/YetAnotherEmptyComponent.vue # examples/snowbox/index.js # src/core/components/PolarMap.ce.vue # src/core/types/plugin.ts # src/plugins/reverseGeocoder/store.ts # src/plugins/reverseGeocoder/utils/reverseGeocodeWps.ts # vue2/packages/plugins/Gfi/CHANGELOG.md # vue2/packages/plugins/Gfi/package.json
|
🏓 @dopenguin Updated
|
dopenguin
left a comment
dopenguin
left a comment
There was a problem hiding this comment.
Can we further specify the search so the results are relevant for the client? The default seems ... not helpful :D
It should be noted that the POLAR nominatim service is currently (due to server constraints) limited to geocoding in Lower Saxony. |
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
The TODO is moved to #747
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
dopenguin
left a comment
dopenguin
left a comment
There was a problem hiding this comment.
Can we further specify the search so the results are relevant for the client? The default seems ... not helpful :D
🏓 @oeninghe-dataportIt should be noted that the POLAR nominatim service is currently (due to server constraints) limited to geocoding in Lower Saxony.
Is it possible to update the POLAR nominatim service to include Hamburg as the snowbox typically uses a lot of Hamburg specific services?
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
| .filter((x) => x) | ||
| .join(', '), | ||
| properties: result.properties, | ||
| properties: {}, |
There was a problem hiding this comment.
According to the docs, that field does not exist. Not quite sure why I assumed that earlier.
There was a problem hiding this comment.
Probably because we can request GeoJSON. Have you tried that before?
There was a problem hiding this comment.
Yes, I tried that earlier. Both work flawlessly, however, the JSONv2 structure is IMO easier and I preferred it therefore. A Nominatim-specific implementation is necessary either way.
There was a problem hiding this comment.
The response may be slightly easier to parse, but information of the feature is lost. It seems preferrable to use 'geojson' as the response format in order to easily add the properties here.
There was a problem hiding this comment.
The type cast on const properties = feature.properties as NominatimReverseGeocodeProperties is redundant as const result: FeatureCollection<Point, NominatimReverseGeocodeProperties> would do the trick.
This also removes the need for the feature.geometry.type !== 'Point'-check.
…ponse Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
a353df3 to
6a19ea0
Compare
There was a problem hiding this comment.
Also, do we have an update on the following from #606 (review)?
Is it possible to update the POLAR nominatim service to include Hamburg as the snowbox typically uses a lot of Hamburg specific services?
There is no reply on this yet, I'll put it on the agenda of our weekly. |
|
The GeoJSON properties of the reverse geocoder with nominatim are preserved as properties of the result.
e62779e to
de4b588
Compare
2 participants
Summary
Add support for nominatim in addressSearch and reverseGeocoder
Instructions for local reproduction and review
Snowbox-integrated