Repository navigation
Report Typefully HTTP rejections without exposing private data - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typefully HTTP rejections were reported as connection failures because urllib raises HTTPError before the transport returns a status. The connector now reports the HTTP status and its standard reason phrase while keeping true network errors generic.
No provider response bodies, headers, request URLs, or arbitrary exception reasons are included in the error. Draft handling and retries are unchanged.
Validation: 31 targeted Typefully tests pass, including default-transport HTTP rejection tests with private-data sentinels and separate network-error coverage.