Repository navigation
Apply Windows credential ACLs without audit privileges - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplying an owner-only ACL to an existing Windows credential file could fail because Set-Acl requested the SeSecurityPrivilege audit privilege. The account did not need broader privileges to update its own file's access rules.
Apply the same explicit owner-only ACL through System.IO.File.SetAccessControl, which only writes the security sections changed by the ACL builder. Extend the credential privacy regression to protect an already-protected file twice.
Validation: all three Windows ACL tests pass. Repeated protection and privacy validation also passed on the existing desktop credential file without reading its contents or exposing token values.