Repository navigation
Fix Windows credential ACLs from PowerShell 7 - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dapier sign-in from a PowerShell 7 host saved the session and then failed while applying owner-only Windows file permissions. The Python child inherited PowerShell 7 module paths, causing Windows PowerShell to load an incompatible Security module.
Load the Security module from the invoked shell's own PSHOME before applying or inspecting ACLs. Add a regression with an incompatible module ahead of the built-ins, and run credential privacy tests on Windows CI. The shared-file fixture edits only the DACL so it needs no audit privileges.
Validation: all three credential ACL tests pass on the affected Windows desktop, including the incompatible-module regression; no credential values are read or emitted.