Repository navigation
Complete Google CLI reply handling, account selection and console parity - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gmail reply drafts lost their thread and reply headers when edited; attachment downloads decoded Gmail's base64url as ordinary base64. Preserve threading across draft updates, parse named reply recipients without exposing Bcc, support explicit reply recipients, and decode binary downloads correctly.
Require an explicit account across Gmail, Drive and Calendar even with one connection. Complete JSON search/draft pagination, supplied-field previews, Calendar partial updates, reviewed payload/timezone mapping and attachment support, plus Drive metadata-only and empty-content updates.
Connections → Google tools exposes the same operations through session/CSRF/role-gated admin aliases to the existing handlers. No provider business logic is duplicated in the console. All 12 composition/Drive/Calendar entrypoint preview scenarios were also checked; Drive mkdir now forwards its preview flag without an API call. Local Google skills document the CLI and remaining read-only fallbacks.
Validation:
make testat 1022631: 4,812 passed, 1 skipped, 42 subtests passed. Chromium verifies reply-draft preview, binary attachment selection and selected-account isolation and paged connection-row access using mocked requests. Safe live reads succeeded for both Gmail inboxes, both Drive accounts and personal/Orin calendars. No live sends, invitations, shares or destructive mutations were tested.Limits: base64 JSON transfers must fit API size limits; resumable uploads and permission list/edit/remove are not exposed. Original
.eml, all-drive corpus sweeps and multi-tab Sheets exports retain the read-only helper. Canonical bots-management skill migration follows deployment.