fix(cdc): normalize zero length varchar metadata#4558
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #4556.
When CDC metadata contains a string-like column with length
0(for example from a MySQLENUMcolumn),DataTypeConverter#getLogicalTypepassed that value directly to Flink'sVarCharType. Flink rejectsVARCHAR(0)and throws:Changes
VarCharType.MAX_LENGTHbefore creating the Flink logical type.DataTypeConverter.Verification
Ran locally with JDK 17:
Result: build success,
DataTypeConverterTestpassed.