Skip to content

Fix Registry Center - Documentation cannot paginate / cannot turn pages #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
safishhh wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix Registry Center - Documentation cannot paginate / cannot turn pages #4554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa2b9cc
Fix Registry Center - Documentation cannot paginate / cannot turn pages
safishhh Jun 9, 2026
62b3769
Improve decimal type conversion in DorisTypeConvert
safishhh Jun 10, 2026
9ea5a22
Enhance decimal type conversion in StarRocksTypeConvert
safishhh Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dinky-admin/src/main/java/org/dinky/mybatis/util/ProTableUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ private static void buildDelete(QueryWrapper<?> wrapper, boolean camelToUndersco
private static void buildSort(
String sortField, String sortValue, QueryWrapper<?> wrapper, boolean camelToUnderscore) {
if (sortField != null && sortValue != null) {
// 过滤无效的排序字段
if ("undefined".equalsIgnoreCase(sortField) || "null".equalsIgnoreCase(sortField) || sortField.trim().isEmpty()) {
return;
}
if (camelToUnderscore) {
sortField = CaseFormat.LOWER_CAMEL.to(CaseFormat.LOWER_UNDERSCORE, sortField);
}
Expand Down
7 changes: 6 additions & 1 deletion ...adata/dinky-metadata-doris/src/main/java/org/dinky/metadata/convert/DorisTypeConvert.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@ public String convertToDB(ColumnType columnType) {
return "varchar";
}
switch (columnType.getValue()) {
case DECIMAL:
case DECIMAL:
if (columnType.getLogicalType() instanceof org.dinky.data.types.DecimalType) {
org.dinky.data.types.DecimalType decimalType =
(org.dinky.data.types.DecimalType) columnType.getLogicalType();
return String.format("decimal(%d,%d)", decimalType.getPrecision(), decimalType.getScale());
}
return "decimal";
case BIGINT:
return "bigint";
Expand Down
5 changes: 5 additions & 0 deletions ...nky-metadata-starrocks/src/main/java/org/dinky/metadata/convert/StarRocksTypeConvert.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ public String convertToDB(ColumnType columnType) {
}
switch (columnType.getValue()) {
case DECIMAL:
if (columnType.getLogicalType() instanceof org.dinky.data.types.DecimalType) {
org.dinky.data.types.DecimalType decimalType =
(org.dinky.data.types.DecimalType) columnType.getLogicalType();
return String.format("decimal(%d,%d)", decimalType.getPrecision(), decimalType.getScale());
}
return "decimal";
case BIGINT:
return "bigint";
Expand Down
Loading