chore(docs): RFC 0015 opportunistic no_std#1964
Draft
pawelchcki wants to merge 1 commit into
Draft
Conversation
Propose a workspace policy that prefers `no_std + alloc` and uses `std` only where it earns its keep. Motivated by signal safety, smaller artifacts, and tighter dependency hygiene.
666e263 to
6da17cf
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: 6da17cf | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
==========================================
- Coverage 72.63% 72.62% -0.01%
==========================================
Files 448 448
Lines 73582 73582
==========================================
- Hits 53443 53436 -7
- Misses 20139 20146 +7
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds RFC 0015 proposing a workspace policy: prefer
no_std + alloc; usestdonly where it earns its keep.Motivation
no_stdis, for a lot of what libdatadog does, the better Rust.coremakes async-signal-unsafe items unreachable by construction (relevant for crashtracker and profiling samplers), embedders linking statically pay for less code, and once a crate isno_stdevery new dependency comes with a forced "what does this drag in?" review.Many migrations are mechanical (
std::→core::, see yaml/yaml-serde#8). #1770 is the in-flight reference implementation forlibdd-library-config.How to test the change?
Read it. Comment if you disagree.