Prevent payload corruption on buffer overflow - #329
Merged
Conversation
If caller tries to serialize a metric larger than the payload size limit, we throw BufferOverflow exception, and the user is requested to call `resetMetric`. Previously, it failed to correctly rewind everything, in particular interners and delta encoders, to the state they had prior to the errant metric, and subsequent entries using dictionary elements of the failed metric would produce dangling references. This patch adds commit/revert methods to Interner and DeltaEncoder. When the record in progress is added to the final payload, we make the state of inerner and encoder permanent. On failure, revert resets to the last committed state.
vickenty
marked this pull request as ready for review
August 12, 2026 08:57
atanzu
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If caller tries to serialize a metric larger than the payload size limit, we throw BufferOverflow exception, and the user is requested to call
resetMetric. Previously, it failed to correctly rewind everything, in particular interners and delta encoders, to the state they had prior to the errant metric, and subsequent entries using dictionary elements of the failed metric would produce dangling references.This patch adds commit/revert methods to Interner and DeltaEncoder. When the record in progress is added to the final payload, we make the state of inerner and encoder permanent. On failure, revert resets to the last committed state.