Skip to content

Remove copy_file workaround from nghttp2 build #46182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Feb 11, 2026
Merged

Remove copy_file workaround from nghttp2 build #46182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ bazel_dep(name = "rules_testing", version = "0.9.0", dev_dependency = True)
# Temporary until rules_pkg > 1.2.0 is in BCR
git_override(
module_name = "rules_pkg",
commit = "a9358d57a797f793cedd460939188496c7d30bbf", # main as of Feb 4, 2026
commit = "2bd928123ad46f5b96970f537af073e0acb5b654", # main as of Feb 10, 2026
remote = "https://github.com/bazelbuild/rules_pkg.git",
)

Expand Down
14 changes: 1 addition & 13 deletions deps/nghttp2/nghttp2.BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
load("@@//bazel/rules:dd_agent_expand_template.bzl", "dd_agent_expand_template")
load("@@//bazel/rules:so_symlink.bzl", "so_symlink")
load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
load("@rules_cc//cc:defs.bzl", "cc_library")
load("@rules_license//rules:license.bzl", "license")
load("@rules_pkg//pkg:install.bzl", "pkg_install")
Expand Down Expand Up @@ -142,20 +141,9 @@ pkg_files(
},
)

# This is a hack to work around a bug in rules_pkg.
copy_file(
name = "pull_fetch_ocsp_response",
src = "@@//third_party/nghttp2:fetch-ocsp-response",
out = "fetch-ocsp-response",
)

pkg_files(
name = "fetch_ocsp_response",
# It would be nicer to use the target
# "@@//third_party/nghttp2:fetch-ocsp-response"
# here, but rules_pkg calculates the path as a relative ref to @nghttp2
# instead of the main project.
srcs = [":fetch-ocsp-response"],
srcs = ["@//third_party/nghttp2:fetch-ocsp-response"],
attributes = pkg_attributes(mode = "0755"),
prefix = "embedded/share/nghttp2",
)
Expand Down