PRODUCT-775: support for extensions and PRF on Android, iOS and Windows#1
Merged
keithbucher merged 7 commits intoApr 16, 2026
Merged
Conversation
…lementing on Android or Windows atm
disptr
approved these changes
Apr 13, 2026
disptr
left a comment
There was a problem hiding this comment.
Looks good!
Dropped a couple of comments with nice-to-haves (although I am worried that the JSON parser might break for certain data).
disptr
reviewed
Apr 14, 2026
disptr
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for extensions to our fork of the flutter-passkeys repository. Simple key-value extensions should work. Extensions that require additional parsing may not. However, the driving purpose of this PR is adding support for prf so that we can use it for E2EE from the Dapple Authenticator application. It is based on this PR in the Corbado repository. But that PR is limited to just the prf extension and overall not well-written IMO.
Notes:
evalByCredentialhas not been testedEDIT:
JSON parsing is currently done by custom code on Windows since all the available libraries seemed heavyweight or Chinese controlled. Our parsing needs are fairly minimal, so I think this should be okTo test with our
authenticator-appyou'll need the following in yourpubspec.yaml(andflutter-passkeyschecked out alongsideauthenticator-app)