Skip to content

PRODUCT-775: support for extensions and PRF on Android, iOS and Windows#1

Merged
keithbucher merged 7 commits into
mainfrom
PRODUCT-775-Modify-profile-passkeys-to-enable-PRF
Apr 16, 2026
Merged

PRODUCT-775: support for extensions and PRF on Android, iOS and Windows#1
keithbucher merged 7 commits into
mainfrom
PRODUCT-775-Modify-profile-passkeys-to-enable-PRF

Conversation

@keithbucher
Copy link
Copy Markdown

@keithbucher keithbucher commented Mar 25, 2026

This PR adds support for extensions to our fork of the flutter-passkeys repository. Simple key-value extensions should work. Extensions that require additional parsing may not. However, the driving purpose of this PR is adding support for prf so that we can use it for E2EE from the Dapple Authenticator application. It is based on this PR in the Corbado repository. But that PR is limited to just the prf extension and overall not well-written IMO.

Notes:

  • This has been tested on Android, iOS and Windows
  • evalByCredential has not been tested
    EDIT:
  • JSON parsing is currently done by custom code on Windows since all the available libraries seemed heavyweight or Chinese controlled. Our parsing needs are fairly minimal, so I think this should be ok
  • JSON parsing has been moved to this JSON parser, which seems to fit our minimal needs and be maintained and used by US-based companies

To test with our authenticator-app you'll need the following in your pubspec.yaml (and flutter-passkeys checked out alongside authenticator-app)

dependencies:
...
  passkeys:
    path: ../../flutter-passkeys/packages/passkeys/passkeys
...
dependency_overrides:
...
  passkeys_android:
    path: ../../flutter-passkeys/packages/passkeys/passkeys_android
  passkeys_darwin:
    path: ../../flutter-passkeys/packages/passkeys/passkeys_darwin
  passkeys_platform_interface:
    path: ../../flutter-passkeys/packages/passkeys/passkeys_platform_interface
  passkeys_web:
    path: ../../flutter-passkeys/packages/passkeys/passkeys_web
  passkeys_windows:
    path: ../../flutter-passkeys/packages/passkeys/passkeys_windows
  passkeys_doctor:
    path: ../../flutter-passkeys/packages/passkeys/passkeys_doctor

@keithbucher keithbucher changed the title PRODUCT-775: support for extensions and PRF on Android and iOS PRODUCT-775: support for extensions and PRF on Android, iOS and Windows Apr 9, 2026
Copy link
Copy Markdown

@disptr disptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dropped a couple of comments with nice-to-haves (although I am worried that the JSON parser might break for certain data).

Comment thread packages/passkeys/passkeys_windows/windows/passkeys_windows_plugin.cpp Outdated
@keithbucher keithbucher requested a review from disptr April 14, 2026 20:55
@keithbucher keithbucher requested a review from disptr April 15, 2026 16:29
@keithbucher keithbucher merged commit d283e00 into main Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants