Fgalizzi opflash#136
Conversation
… WITH EMPTY ARRAYS commit
Merge develop into fgalizzi_opflash
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for DUNE Succeeded on slf7 for c14:prof -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests DUNE phase logs parent CI build details are available through the CI dashboard |
|
CI major issues: CI is failing because of a missing file I checked via dunegpvms and the @FNALbuild @DUNE/software-release-managers could you check this issue? |
| double MaxPE = 0; | ||
| std::vector<double> PEperOpDet = {}; | ||
| size_t NOpDets = art::ServiceHandle<geo::Geometry>()->NOpDets(); | ||
| std::vector<double> PEperOpDet(NOpDets, 0.); |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for DUNE Succeeded on slf7 for c14:prof -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests DUNE phase logs parent CI build details are available through the CI dashboard |
mantheys
left a comment
mantheys
left a comment
There was a problem hiding this comment.
This is a nice improvement! Thanks, Federico!!!
|
Hi devs and reviewers, thanks for your contribution! We're merging this PR for the v10_20_06 release. |
5 participants
With this pull request we adapt the creation and the filling of PEperOpDet in duneopdet/LowEPDSUtils/AdjOpHitsUtils.cc in view of the Maximum Likelihood Flashmatching algorithm.
The change is necessary to store the hit and unhit information of all the OpDets in a flash