Skip to content

Updating wvf pre-processing#135

Merged
leoaliaga merged 9 commits intodevelopfrom
lp_wvfpreprocess
May 4, 2026
Merged

Updating wvf pre-processing#135
leoaliaga merged 9 commits intodevelopfrom
lp_wvfpreprocess

Conversation

@lpaulucc
Copy link
Copy Markdown
Member

@lpaulucc lpaulucc commented Apr 6, 2026

This PR introduces the following changes to the pre-processing module:

  1. Makes the baseline fluctuation removal optional;
  2. Only applies baseline fluctuation removal if saturation is not "too large" (fhicl adjustable);
  3. For number 2 to work, baseline fluctuation removal and denoising order was altered;
  4. Always include a "dent" correction to saturated waveforms. Some waveforms (particularly in C8) show what is possibly a temporary laser failure that creates an artificial decrease in charge during saturation.

Note that fhicl parameters for this module have not yet been optimized for PDVD data.

@lpaulucc lpaulucc requested a review from vpec0 April 6, 2026 19:03
@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for DUNE Succeeded with warning at phase build on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

Copy link
Copy Markdown
Member

@vpec0 vpec0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Laura, I have included a few comments/suggestions for changes.

Comment thread duneopdet/OpticalDetector/WaveformPreProcessing.fcl Outdated
Comment thread duneopdet/OpticalDetector/WaveformPreProcessing.fcl Outdated
Comment thread duneopdet/OpticalDetector/WaveformPreProcessing.fcl Outdated
Comment thread duneopdet/OpticalDetector/WaveformPreProcessing_module.cc Outdated
@leoaliaga
Copy link
Copy Markdown
Member

trigger build

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

❌ CI build for DUNE Failed at phase build DUNE on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build DUNE phase logs

parent CI build details are available through the CI dashboard

@wyjang-uta
Copy link
Copy Markdown
Member

trigger build

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for DUNE Succeeded on slf7 for c14:prof -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

@leoaliaga leoaliaga merged commit c47b1ad into develop May 4, 2026
4 checks passed
@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests DUNE phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants