[2.0.0] Remove isis_formatter and usgscsm_formatter#698
Conversation
| formatter : {'ale'} ('isis', and 'usgscsm' are deprecated) | ||
| Output format for the ISD. As of 1.2.0, the | ||
| `ale` formatter is always used. The parameter is retained | ||
| for backwards compatibility. |
There was a problem hiding this comment.
Everything looks good but a breaking change like this would require a version tick to ALE 2.0.0. In ISIS we usually hold any breaking change for the yearly release, I don't know what we should do for ALE. With the spiceql changes and the gdal additions we could likely do a 2.0.0. @Kelvinrr thoughts?
There was a problem hiding this comment.
we should probably hold off on this for this reason. At least we should see if there are more API breaking changes we can pile on.
There was a problem hiding this comment.
The code removed is ancient and not used by anybody. Likely ALE 2.0.0 bump is needed simply because of adding the ShadowCam lens distortion which breaks the enums.
I'd say the risk of this is very low. Also, likely next ISIS need to have a hard pin to this as well, and with usgscsm and spiceql too, all because of ShadowCam. There's no good reason for the user to want independent versions for these.
Fixes #653
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: