Skip to content

Parallel II Estimator#1842

Open
BDoignies wants to merge 36 commits into
mainfrom
parallelII
Open

Parallel II Estimator#1842
BDoignies wants to merge 36 commits into
mainfrom
parallelII

Conversation

@BDoignies

@BDoignies BDoignies commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

PR Description

A new WIP branch for parallel Integral Invariant estimators.

Checklist

  • I have installed and run the pre-commit hooks (cf CONTRIBUTING.md).
  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@BDoignies

Copy link
Copy Markdown
Contributor Author

@dcoeurjo My last commit features the ordered (yet parallel version) of the estimator. I realized that because we rely on the input range for surfel, we have no need to build locally the surface and we can simply extract the required surfels from the range.

Not to blow my own trumpet, but I think the final code looks pretty good :) (And in my computer, even with only 2000 surfels and 4 threads it does run faster than the sequential one)

@BDoignies BDoignies requested a review from dcoeurjo March 12, 2026 09:29
@dcoeurjo

Copy link
Copy Markdown
Member

I will have a look, thanks.
In the meantime, could you please install the precommit scripts and run it on the edited files ?

@dcoeurjo dcoeurjo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just the doc is missing and some LGPL headers. I've added another domain splitter and a unit test for that.
Code should be in "kernel/domains/" subfolder by the way

Comment thread src/DGtal/geometry/surfaces/estimation/ParallelIIEstimator.ih
Comment thread src/DGtal/geometry/surfaces/estimation/ParallelIIEstimator.h
Comment thread src/DGtal/kernel/domains/DomainSplitter.h
@dcoeurjo

dcoeurjo commented Jun 7, 2026

Copy link
Copy Markdown
Member

/builddoc

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

There was an error while building the doc. Check the GitHub actions for debugging.

@dcoeurjo

dcoeurjo commented Jun 7, 2026

Copy link
Copy Markdown
Member

/builddoc

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1842/index.html

@dcoeurjo

dcoeurjo commented Jun 8, 2026

Copy link
Copy Markdown
Member

I've updated the geometry shortcuts to enable multithreaded curvature estimation.

@dcoeurjo

Copy link
Copy Markdown
Member

/builddoc

@github-actions

Copy link
Copy Markdown

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1842/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants