Repository navigation
ADD: security checks in CI, and every action pinned to a commit - #96
Merged
Merged
Conversation
…every action to a commit
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The server holds confidential imaging and its CI only ran the test suite. This adds the checks the Slicer client already runs, and hardens the existing workflows.
Added:
security.yml(pull requests, pushes to main, weekly)server/README.md(Bearer your-...-token) and the word "tokens" in prose; they are listed one fingerprint each in.gitleaksignore, so a real secret is still reported.# nosec <rule>with its reason on the line above (fixed https URLs, the default TEMP_DIR, the agent compiling its ownrelease_diff.py, the operator's own--restart-cmd).server/requirements-api.txt, which is all the server image installs. Currently clean.Added:
codeql.ymlanddependabot.ymlsecurity-extended, results in the Security tab. Free on a public repository.Hardened:
tests.ymlandserver-image.ymlzizmor reported nine findings; all are fixed:
persist-credentials: falseon every checkout, so no git token sits in the workspace a build reads;server-image.ymlno longer interpolatessecrets.GITHUB_TOKENandgithub.actorinto the shell script; they go throughenv.Checked locally
zizmor: no findings. bandit: clean. gitleaks: no leaks. pip-audit: no known vulnerabilities. Server suite: 1495 passed, known
test_dev_mountsfailure unchanged.