Repository navigation
FIX: keep a resumed run's tool name when the server restarted while it was paused - #95
Merged
Jules-GP merged 1 commit intoOct 29, 2026
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The admin panel listed a finished run as
(unnamed).The run ledger is kept in memory, and the history on disk only holds finished runs. When the server restarts while a run is paused at a checkpoint, that run's ledger record is lost. When the run is resumed,
record_run_grantmeets an unknown id and creates a blank record. The result is no tool, no client, and a start time equal to the resume time. The run itself completed normally; only its bookkeeping was wrong.Fix
telemetry.record_run_resumed()fills in only the fields the record is missing: tool, client, batch, and the original start time.POST /runs/{id}/resumecalls it with themeta.jsonthe run wrote when it registered. That file is still beside its events.Tests
test_telemetry.py: a resume after a restart keeps the run's name, and a resume never renames a run the ledger already knows.test_quality_control.py: register, pause, clear the ledger (the restart), resume through the endpoint. It fails without the fix.test_dev_mounts. That test also fails onmain(VFACE is neither mounted nor declared image-served).