Repository navigation
FIX: name each AREG IOS-CBCT patient folder as its files do and hand back the oriented CBCT beside the meshes - #88
Merged
Jules-GP merged 1 commit intoOct 27, 2026
Conversation
…back the oriented CBCT beside the meshes
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A cohort run showed two problems with the AREG IOS-CBCT results.
case_042_T1_U.stllanded in a folder called42. Nothing on disk ties42back tocase_042.Change
Folder names
pipeline.patient_name(): it keeps the name up to the end of its first word that holds a digit, skipping a timepoint word.case_042_T1_L.stlgivescase_042P_0001_T2.nii.gzgivesP_0001discover()still pairs onpatient_key, and the landmark files are still matched on it. Each pair now also carries itsname, taken from the patient's first intraoral mesh (the files the folder holds).patients/unpairedkeys ofAREG_report.jsonuse the name.The oriented CBCT
<scan>_Or.nii.gz;<scan>_Or_transform.tfm(original scan to oriented one), for a reader who wants the meshes on the original scan instead.oriented_cbct,cbct_transform).Compatibility
The report's patient keys change from the digit key (
"1") to the name ("P001"). Nothing in the server or the Slicer client reads those keys.Tests
patient_name, for two keys that would share a name, and for Fully-Automated handing back the oriented CBCT and its transform, while Semi-Automated does not.