Skip to content

Offer the steps-to-keep check box on the AREG panels - #81

Merged
Jules-GP merged 1 commit into
DCBIA-OrthoLab:mainfrom
Jules-GP:feat/areg-keep-intermediate
Oct 20, 2026
Merged

Jules-GP merged 1 commit into
DCBIA-OrthoLab:mainfrom
Jules-GP:feat/areg-keep-intermediate

Conversation

@Jules-GP

Copy link
Copy Markdown
Collaborator

The three AREG layouts (AREG_CBCT, AREG_IOS, AREG_IOSCBCT) hid keep_intermediate, the argument the server injects for any tool that calls another and the client renders from the schema. ASO, ALI_IOS and VFACE already show it. This replaces {"hidden": True} with the label "Steps to keep" and one explanation per called tool; stop_after stays hidden. Nothing changes in the server or the client.

The server collects only the output of the calls a tool makes itself, so ticking ASO in AREG returns ASO's own result, not what ALI predicted underneath it.

Each tool gets one test asserting the box is not hidden, carries the label, and explains exactly the tools it calls. Tested with -m "not gpu": AREG_IOS 86 passed, AREG_IOSCBCT 209 passed, AREG_CBCT 156 passed and 3 failed in tests/test_masks.py::test_the_registration_mask_wins_over_the_anatomy_beside_it, which fail identically without this change.

Copilot AI balanced review requested due to automatic review settings October 20, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Jules-GP
Jules-GP merged commit a8c0ca2 into DCBIA-OrthoLab:main Oct 20, 2026
22 checks passed
@Jules-GP
Jules-GP deleted the feat/areg-keep-intermediate branch October 20, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants