Skip to content

Fix PHP 8.4 implicit nullable parameter deprecation (CMS-2804) #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabianwgl merged 2 commits into from
Sep 10, 2026
Merged

Fix PHP 8.4 implicit nullable parameter deprecation (CMS-2804) #376

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69a33bf
Fix PHP 8.4 implicit nullable parameter deprecation
fabianwgl Sep 8, 2026
393c62f
Drop array type hint instead of using nullable syntax
fabianwgl Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/traits/Class_Constant_Override_Validator_Trait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ protected function validate_required_array_class_constants( array $required_arra
*
* @throws Exception
*/
protected function validate_required_array_class_constant( $required_array_constant_name, array $allowed_item_values = null ) {
protected function validate_required_array_class_constant( $required_array_constant_name, ?array $allowed_item_values = null ) {
Comment thread
qodo-code-review[bot] marked this conversation as resolved.
Outdated
Comment thread
apinto-uc marked this conversation as resolved.
Outdated
if ( ! is_string( $required_array_constant_name ) ) {
throw new InvalidArgumentException();
}
Expand Down
Loading