Array import magic#365
Open
nealrichardson wants to merge 7 commits intomasterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 90.37% 90.22% -0.16%
==========================================
Files 115 116 +1
Lines 7325 7354 +29
==========================================
+ Hits 6620 6635 +15
- Misses 705 719 +14
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 90.37% 90.22% -0.16%
==========================================
Files 115 116 +1
Lines 7325 7354 +29
==========================================
+ Hits 6620 6635 +15
- Misses 705 719 +14
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array/MR variables coming in from SPSS or other lossy file formats generally need some work to reconstruct the "right" metadata because they have to shove both parent and subvariable metadata into the "varlabels" of the subvariables. This often follows a pattern of having varlabels with a prefix containing the parent question wording (description) and a suffix that is the actual response label. (We also do this when we "unbind" an array.)
These functions allow us to detect this metadata pattern and attempt to repair it.
To do:
makeArray()so that this detection happens when the array is createdUltimately we may want this done server side, but this will help us now and will inform any backend implementation.