Skip to content

Archiver reader lock refactor #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacomago merged 10 commits into from
May 28, 2026
+1,599 −107

Move per-source read timeout to outer polling loop

4d19a4f
Select commit
Loading
Failed to load commit list.
Merged

Archiver reader lock refactor #3807

Move per-source read timeout to outer polling loop
4d19a4f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 27, 2026 in 2m 40s

Quality Gate passed

Issues
29 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 332 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF-&open=AZ5k0XyQj_7NZQq5cEF-&pullRequest=3807

Check warning on line 119 in app/trends/archive-reader/src/test/java/org/phoebus/archive/reader/appliance/ApplianceValueIteratorConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this block of code, fill it in, or add a comment explaining why it is empty. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0Xyaj_7NZQq5cEGE&open=AZ5k0Xyaj_7NZQq5cEGE&pullRequest=3807

Check warning on line 172 in app/trends/archive-reader/src/main/java/org/phoebus/archive/reader/appliance/ApplianceArchiveReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Lambda should be used to defer string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0X0aj_7NZQq5cEGJ&open=AZ5k0X0aj_7NZQq5cEGJ&pullRequest=3807

Check failure on line 355 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEGC&open=AZ5k0XyQj_7NZQq5cEGC&pullRequest=3807

Check failure on line 288 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF4&open=AZ5k0XyQj_7NZQq5cEF4&pullRequest=3807

Check warning on line 135 in app/trends/archive-reader/src/main/java/org/phoebus/archive/reader/appliance/ApplianceArchiveReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Lambda should be used to defer string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0X0aj_7NZQq5cEGG&open=AZ5k0X0aj_7NZQq5cEGG&pullRequest=3807

Check failure on line 353 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEGA&open=AZ5k0XyQj_7NZQq5cEGA&pullRequest=3807

Check failure on line 308 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF6&open=AZ5k0XyQj_7NZQq5cEF6&pullRequest=3807

Check warning on line 100 in app/trends/archive-reader/src/test/java/org/phoebus/archive/reader/appliance/ApplianceArchiveReaderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0Xyjj_7NZQq5cEGF&open=AZ5k0Xyjj_7NZQq5cEGF&pullRequest=3807

Check warning on line 174 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJob.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0Xsoj_7NZQq5cEFq&open=AZ5k0Xsoj_7NZQq5cEFq&pullRequest=3807

Check warning on line 223 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJob.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "testOnly". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0Xsoj_7NZQq5cEFu&open=AZ5k0Xsoj_7NZQq5cEFu&pullRequest=3807

Check warning on line 57 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/preferences/Preferences.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "archive_read_timeout_ms" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyGj_7NZQq5cEFw&open=AZ5k0XyGj_7NZQq5cEFw&pullRequest=3807

Check failure on line 164 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEFz&open=AZ5k0XyQj_7NZQq5cEFz&pullRequest=3807

Check failure on line 289 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF5&open=AZ5k0XyQj_7NZQq5cEF5&pullRequest=3807

Check failure on line 354 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEGB&open=AZ5k0XyQj_7NZQq5cEGB&pullRequest=3807

Check failure on line 235 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF2&open=AZ5k0XyQj_7NZQq5cEF2&pullRequest=3807

Check failure on line 197 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF0&open=AZ5k0XyQj_7NZQq5cEF0&pullRequest=3807

Check warning on line 115 in app/trends/archive-reader/src/test/java/org/phoebus/archive/reader/appliance/ApplianceValueIteratorConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this block of code, fill it in, or add a comment explaining why it is empty. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0Xyaj_7NZQq5cEGD&open=AZ5k0Xyaj_7NZQq5cEGD&pullRequest=3807

Check warning on line 57 in app/databrowser/src/main/java/org/csstudio/trends/databrowser3/preferences/Preferences.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static archive_read_timeout_ms" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyGj_7NZQq5cEFv&open=AZ5k0XyGj_7NZQq5cEFv&pullRequest=3807

Check failure on line 262 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF3&open=AZ5k0XyQj_7NZQq5cEF3&pullRequest=3807

Check failure on line 198 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF1&open=AZ5k0XyQj_7NZQq5cEF1&pullRequest=3807

Check failure on line 310 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF8&open=AZ5k0XyQj_7NZQq5cEF8&pullRequest=3807

Check warning on line 160 in app/trends/archive-reader/src/main/java/org/phoebus/archive/reader/appliance/ApplianceArchiveReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Lambda should be used to defer string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0X0aj_7NZQq5cEGI&open=AZ5k0X0aj_7NZQq5cEGI&pullRequest=3807

Check failure on line 333 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEF_&open=AZ5k0XyQj_7NZQq5cEF_&pullRequest=3807

Check failure on line 139 in app/databrowser/src/test/java/org/csstudio/trends/databrowser3/archive/ArchiveFetchJobTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5k0XyQj_7NZQq5cEFy&open=AZ5k0XyQj_7NZQq5cEFy&pullRequest=3807
View more details on SonarQubeCloud