Skip to content

Add certificate status gating for PVA TLS connections #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
george-mcintyre wants to merge 6 commits into
base: master
Choose a base branch
from
+795 −64

Fix TLS connection mismatch in PVAClient computeIfAbsent

47bf42f
Select commit
Loading
Failed to load commit list.
Open

Add certificate status gating for PVA TLS connections #3786

Fix TLS connection mismatch in PVAClient computeIfAbsent
47bf42f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 15, 2026 in 2m 55s

Quality Gate passed

Issues
45 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 64 in core/pva/src/main/java/org/epics/pva/server/ServerTCPListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "server_own_cert_listener" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMe2yQ1ZEneHtSBR&open=AZ2RnMe2yQ1ZEneHtSBR&pullRequest=3786

Check warning on line 72 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "server_own_cert_info" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfhyQ1ZEneHtSBi&open=AZ2RnMfhyQ1ZEneHtSBi&pullRequest=3786

Check warning on line 318 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers or lambda should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMjsyQ1ZEneHtSBz&open=AZ2RnMjsyQ1ZEneHtSBz&pullRequest=3786

Check warning on line 314 in core/pva/src/main/java/org/epics/pva/common/CertificateStatus.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfOyQ1ZEneHtSBS&open=AZ2RnMfOyQ1ZEneHtSBS&pullRequest=3786

Check warning on line 271 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make EPICS_PVA_CERT_STATUS_TMO a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMjsyQ1ZEneHtSBt&open=AZ2RnMjsyQ1ZEneHtSBt&pullRequest=3786

Check warning on line 181 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers or lambda should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfiyQ1ZEneHtSBn&open=AZ2RnMfiyQ1ZEneHtSBn&pullRequest=3786

Check warning on line 271 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "EPICS_PVA_CERT_STATUS_TMO" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMjsyQ1ZEneHtSBx&open=AZ2RnMjsyQ1ZEneHtSBx&pullRequest=3786

Check warning on line 89 in core/pva/src/main/java/org/epics/pva/server/ServerTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "client_cert_status_gate" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMegyQ1ZEneHtSBL&open=AZ2RnMegyQ1ZEneHtSBL&pullRequest=3786

Check warning on line 176 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfhyQ1ZEneHtSBW&open=AZ2RnMfhyQ1ZEneHtSBW&pullRequest=3786

Check warning on line 92 in core/pva/src/main/java/org/epics/pva/server/ServerTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "pending_channel_creates" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMegyQ1ZEneHtSBM&open=AZ2RnMegyQ1ZEneHtSBM&pullRequest=3786

Check warning on line 146 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfhyQ1ZEneHtSBV&open=AZ2RnMfhyQ1ZEneHtSBV&pullRequest=3786

Check warning on line 228 in core/pva/src/main/java/org/epics/pva/client/ClientTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMaPyQ1ZEneHtSBC&open=AZ2RnMaPyQ1ZEneHtSBC&pullRequest=3786

Check warning on line 146 in core/pva/src/main/java/org/epics/pva/client/ClientTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "queued_data_ops" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMaPyQ1ZEneHtSBK&open=AZ2RnMaPyQ1ZEneHtSBK&pullRequest=3786

Check warning on line 111 in core/pva/src/main/java/org/epics/pva/common/CertificateStatusMonitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMjbyQ1ZEneHtSBr&open=AZ2RnMjbyQ1ZEneHtSBr&pullRequest=3786

Check warning on line 78 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "status_pv_name" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfhyQ1ZEneHtSBj&open=AZ2RnMfhyQ1ZEneHtSBj&pullRequest=3786

Check warning on line 301 in core/pva/src/main/java/org/epics/pva/PVASettings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMjsyQ1ZEneHtSBu&open=AZ2RnMjsyQ1ZEneHtSBu&pullRequest=3786

Check warning on line 93 in core/pva/src/main/java/org/epics/pva/server/ServerTCPListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMe2yQ1ZEneHtSBP&open=AZ2RnMe2yQ1ZEneHtSBP&pullRequest=3786

Check warning on line 280 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfhyQ1ZEneHtSBY&open=AZ2RnMfhyQ1ZEneHtSBY&pullRequest=3786

Check warning on line 134 in core/pva/src/main/java/org/epics/pva/client/ClientTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "cert_status_confirmed" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMaPyQ1ZEneHtSBH&open=AZ2RnMaPyQ1ZEneHtSBH&pullRequest=3786

Check warning on line 95 in core/pva/src/main/java/org/epics/pva/server/ServerTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "cert_status_timeout" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMegyQ1ZEneHtSBN&open=AZ2RnMegyQ1ZEneHtSBN&pullRequest=3786

Check warning on line 81 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "cert_status" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfiyQ1ZEneHtSBk&open=AZ2RnMfiyQ1ZEneHtSBk&pullRequest=3786

Check failure on line 122 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 49 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfiyQ1ZEneHtSBm&open=AZ2RnMfiyQ1ZEneHtSBm&pullRequest=3786

Check failure on line 534 in core/pva/src/main/java/org/epics/pva/common/SecureSockets.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMfiyQ1ZEneHtSBq&open=AZ2RnMfiyQ1ZEneHtSBq&pullRequest=3786

Check warning on line 129 in core/pva/src/main/java/org/epics/pva/client/ClientTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "peer_cert_listener" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMaPyQ1ZEneHtSBG&open=AZ2RnMaPyQ1ZEneHtSBG&pullRequest=3786

Check warning on line 137 in core/pva/src/main/java/org/epics/pva/client/ClientTCPHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "own_cert_gate" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ2RnMaPyQ1ZEneHtSBI&open=AZ2RnMaPyQ1ZEneHtSBI&pullRequest=3786
View more details on SonarQubeCloud