Skip to content

Added file drag-n-drop for opening them #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RobertoRoos wants to merge 2 commits into
base: master
Choose a base branch
from
+104 −45
Draft

Added file drag-n-drop for opening them #3731

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c27ca
First coarse version of a file drag-n-drop
Mar 9, 2026
41c0f64
Enabled file drag-n-drop in DockPane too
Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions core/ui/src/main/java/org/phoebus/ui/application/PhoebusApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@
import javafx.scene.input.KeyCombination;
import javafx.scene.input.KeyEvent;
import javafx.scene.input.MouseEvent;
import javafx.scene.input.Dragboard;
import javafx.scene.input.TransferMode;
import javafx.scene.layout.BorderPane;
import javafx.scene.layout.GridPane;
import javafx.scene.layout.HBox;
Expand Down Expand Up @@ -487,6 +489,27 @@ private void startUI(final MementoTree memento, final JobMonitor monitor) throws
toolbar = createToolbar();
createTopResourcesMenu();

menuBar.setOnDragOver(e -> {
Copy link
Copy Markdown
Author

@RobertoRoos RobertoRoos Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be a good location to put this event method? Because the event-handler should be shared, as I would like it to be called from other panels too.

final Dragboard db = e.getDragboard();
if (db.hasFiles()) // Allow any drag operation containing files
e.acceptTransferModes(TransferMode.MOVE);

e.consume();
});

menuBar.setOnDragDropped(e -> {
final Dragboard db = e.getDragboard();

if (db.hasFiles()) {
for (File file : db.getFiles()) {
this.openResource(file.toURI(), true);
}
}

e.setDropCompleted(true);
e.consume();
});
Copy link
Copy Markdown
Author

@RobertoRoos RobertoRoos Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but causes the dragged-file icon to still show on top of the UI file the 'Choose editor' dialog is open.
What is a neat way to delay the openResource() call by a little bit?

Copy link
Copy Markdown
Collaborator

@kasemir kasemir Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling this.openResource(...) right there, try deferring it to the next UI cycle via

 Platform.runLater(() -> this.openResource(...));


DockStage.configureStage(main_stage);
// Patch ID of main window
// (in case we ever need to identify the main window)
Expand Down