Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:
- package-ecosystem: "pip" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
interval: "monthly"
target-branch: "develop"
19 changes: 19 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
## What

_what the PR changes_

## Why

_why these changes were made_

## Test Plan

_how did you verify these changes did what you expected_

## Env Vars

_did you add, remove, or rename any environment variables_

## Checklist

- [ ] Tested all changes locally
3 changes: 1 addition & 2 deletions selections/blueprints/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ def get_application(app_id, info=None):
'vote.html',
application=applicant_info,
pdf_url='/application/content/'+app_id,
info=info,
fields=fields)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given, i definitely could just test this to see if it works but that sounds like a lot of thought

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linting failure was for "unused variable" here. I couldn't even find a definition of what it was.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I lied, it was for variable undefined. vote.html needs it. I misunderstood the problem. I thought it didn't need fields, hence why it was undefined, but in fact "fields" was deleted from this function somewhere along the way. Very good catch. Thank you

info=info)

@app.route('/application/content/<app_id>')
@auth.oidc_auth("default")
Expand Down
4 changes: 2 additions & 2 deletions selections/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class Applicant(db.Model):
__tablename__ = 'application'
id = Column(Integer, primary_key=True)
created = Column(DateTime(timezone=True), server_default=func.now(), nullable=False)
created = Column(DateTime(timezone=True), server_default=func.now(), nullable=False) #pylint: disable=not-callable
body = Column(String(6000), nullable=True)
team = Column(Integer, nullable=False)
gender = Column(String(15), nullable=False)
Expand All @@ -26,7 +26,7 @@ class Members(db.Model):

class Submission(db.Model):
id = Column(Integer, primary_key=True)
created = Column(DateTime(timezone=True), server_default=func.now(), nullable=False)
created = Column(DateTime(timezone=True), server_default=func.now(), nullable=False) #pylint: disable=not-callable
application = Column(Integer, ForeignKey('application.id'), nullable=False)
member = Column(String(50), ForeignKey('members.username'), nullable=False)
medium = Column(interview_enum, primary_key=True)
Expand Down