Skip to content

Add affected app PR image builds#1470

Merged
kilemensi merged 10 commits into
mainfrom
apps-pr-build-targets
May 5, 2026
Merged

Add affected app PR image builds#1470
kilemensi merged 10 commits into
mainfrom
apps-pr-build-targets

Conversation

@kilemensi

@kilemensi kilemensi commented May 4, 2026

Copy link
Copy Markdown
Member

Description

This adds PR-time production image validation for apps that have migrated to the Docker bake build path.

For trusted PRs, the workflow detects which buildable apps are affected and builds only those app images without pushing them. This gives us a PR signal for production-image breakages without rebuilding every migrated app on every PR.

Behaviour

  • Runs for PRs that touch build-relevant app, package, workflow, lockfile, or Docker bake files.
  • Builds affected migrated apps only.
  • Skips image builds for fork or otherwise untrusted PRs.
  • Uses the published base image tag configured by UI_BASE_TAG.
  • Does not validate docker/base.Dockerfile; base images remain on their separate release workflow.

Implementation Notes

  • Adds a PR Build workflow for affected app image validation.
  • Adds scripts/pr-build-targets.mjs to compute affected build targets using turbo ls --affected plus explicit build-input rules.
  • Adds app-specific reusable build workflows:
    • _build-techlabblog.yml
    • _build-trustlab.yml
  • Renames the generic bake workflow to _bake-and-push.yml and keeps it as the low-level reusable bake primitive.
  • Updates techlabblog.yml and trustlab.yml to reuse their app-specific build workflows.
  • Updates root test scripts so script-level tests run in CI.

Validation

pnpm test:scripts
pnpm exec turbo format:check

Fixes #1469

Type of change

  • Chore

Screenshots

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kilemensi kilemensi self-assigned this May 4, 2026
@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label May 4, 2026
@kilemensi kilemensi added this to COMMONS May 4, 2026
@github-project-automation github-project-automation Bot moved this to 🚧 In Progress in COMMONS May 4, 2026
@kilemensi

This comment was marked as resolved.

@chatgpt-codex-connector

This comment was marked as resolved.

@kilemensi

This comment was marked as resolved.

@claude

This comment was marked as resolved.

@kilemensi

This comment was marked as resolved.

@claude

This comment was marked as resolved.

@kilemensi

This comment was marked as resolved.

@claude

This comment was marked as resolved.

@kilemensi kilemensi requested review from a team, kelvinkipruto and koechkevin May 5, 2026 10:39
@kilemensi kilemensi added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 58fadd0 May 5, 2026
8 checks passed
@kilemensi kilemensi deleted the apps-pr-build-targets branch May 5, 2026 12:19
@github-project-automation github-project-automation Bot moved this from 🚧 In Progress to ✅ Done in COMMONS May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A task that needs to be done (neither enhancement or bug)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Plan: Re-enable CI build verification through Docker bake

2 participants