stringify integers outside JavaScript's safe range in JSON results - #210
Open
knQzx wants to merge 1 commit into
Open
stringify integers outside JavaScript's safe range in JSON results#210knQzx wants to merge 1 commit into
knQzx wants to merge 1 commit into
Conversation
Large ClickHouse integers (UInt64 and similar) exceed JavaScript's MAX_SAFE_INTEGER, so a JSON consumer parsing them as doubles silently corrupts the value (1875924584784080993 becomes 1875924584784081000). Recursively emit integers whose magnitude exceeds 2^53-1 as strings in the serialized tool result; smaller integers and booleans stay numeric. Closes ClickHouse#111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
large ClickHouse integers (UInt64 and similar) exceed JS
MAX_SAFE_INTEGER, so a JSON consumer parsing them as doubles silently corrupts the value (1875924584784080993 becomes 1875924584784081000)recursively emit integers whose magnitude exceeds 2^53-1 as strings; smaller integers and booleans stay numeric
closes #111