fix: flaky connection test TestConnectionExpiresIdleConnection#1817
Open
fix: flaky connection test TestConnectionExpiresIdleConnection#1817
TestConnectionExpiresIdleConnection#1817Conversation
changes 1. Fixes the proper connection cleanup 2. explicit metrics count based on error checks 3. Tolerate some fluctuations on system.connections to compre the result Signed-off-by: Kaviraj <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This test often fails in the CI and retry always passes. This PR makes it more deterministic.
changes
Checklist
Delete items not relevant to your PR: