Skip to content

fix: preserve original case for DSN query parameter values #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tank-500m wants to merge 3 commits into
base: main
Choose a base branch
from
+55 −3
Open

fix: preserve original case for DSN query parameter values #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f647cf9
fix: preserve original case for DSN query parameter values
tank-500m Mar 19, 2026
bc481aa
Merge branch 'main' into fix/dsn-parser-preserve-setting-value-case
kavirajk Mar 23, 2026
a25a7f6
Merge branch 'main' into fix/dsn-parser-preserve-setting-value-case
tank-500m Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions clickhouse_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,16 +350,17 @@ func (o *Options) fromDSN(in string) error {
}
o.HttpUrlPath = path
default:
switch p := strings.ToLower(params.Get(v)); p {
raw := params.Get(v)
switch p := strings.ToLower(raw); p {
case "true":
o.Settings[v] = int(1)
case "false":
o.Settings[v] = int(0)
default:
if n, err := strconv.Atoi(p); err == nil {
if n, err := strconv.Atoi(raw); err == nil {
o.Settings[v] = n
} else {
o.Settings[v] = p
o.Settings[v] = raw
}
}
}
Expand Down
51 changes: 51 additions & 0 deletions clickhouse_options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,57 @@ func TestParseDSN(t *testing.T) {
},
"",
},
{
"setting value preserves original case",
"clickhouse://127.0.0.1/test_database?log_comment=REQUEST_TYPE:proxy%3BUSER_ID:TEST",
&Options{
Protocol: Native,
TLS: nil,
Addr: []string{"127.0.0.1"},
Settings: Settings{
"log_comment": "REQUEST_TYPE:proxy;USER_ID:TEST",
},
Auth: Auth{
Database: "test_database",
},
scheme: "clickhouse",
},
"",
},
{
"setting boolean true is case insensitive",
"clickhouse://127.0.0.1/test_database?async_insert=True",
&Options{
Protocol: Native,
TLS: nil,
Addr: []string{"127.0.0.1"},
Settings: Settings{
"async_insert": int(1),
},
Auth: Auth{
Database: "test_database",
},
scheme: "clickhouse",
},
"",
},
{
"setting numeric value preserved",
"clickhouse://127.0.0.1/test_database?max_block_size=65505",
&Options{
Protocol: Native,
TLS: nil,
Addr: []string{"127.0.0.1"},
Settings: Settings{
"max_block_size": int(65505),
},
Auth: Auth{
Database: "test_database",
},
scheme: "clickhouse",
},
"",
},
{
"multiple hosts in HA mode",
"clickhouse://127.0.0.1:9440,127.0.0.2:9440/test_database",
Expand Down